Issue 7537003: [Mac] When the Lion gesture preferences are unset, return the intrinsic default of YES.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7537003: [Mac] When the Lion gesture preferences are unset, return the intrinsic default of YES. (Closed)

Created:
9 years, 4 months ago by Robert Sesek

Modified:
9 years, 4 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

[Mac] When the Lion gesture preferences are unset, return the intrinsic default of YES. BUG=90869 TEST=Open ~/Library/Preferences/.GlobalPreferences.plist and delete AppleEnableSwipeNavigateWithScrolls. Use two finger swiping to go back/forward and it works. Toggle the preferences and it obeys that. TEST=Open that file and delete com.apple.swipescrolldirection. Natural scrolling is on by default. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=94762

Patch Set 1 #

Patch Set 2 : '' #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -5 lines)			Patch
	M	chrome/browser/ui/cocoa/gesture_utils.mm	View	1	2 chunks	+20 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Robert Sesek

Can you patch this in, follow the TEST= line and see if it works? Gestures ...

9 years, 4 months ago (2011-07-29 21:07:52 UTC) #1

LGTM and merge it to M14.

Expand Messages | Collapse Messages