Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: net/socket/client_socket_factory.h

Issue 7535007: Implement PPB_Flash_TCPSocket.InitiateSSL. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: . Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/socket/client_socket_factory.h
diff --git a/net/socket/client_socket_factory.h b/net/socket/client_socket_factory.h
index c2e03505a7a0b46e366c0d191c4c86ed9e9c43b3..c5e3dda903aaf0a5651ff94c952b94e01ed99bc3 100644
--- a/net/socket/client_socket_factory.h
+++ b/net/socket/client_socket_factory.h
@@ -47,6 +47,9 @@ class NET_API ClientSocketFactory {
NetLog* net_log,
const NetLog::Source& source) = 0;
+ // It is allowed to pass in a |transport_socket| that is not obtained from a
+ // socket pool. The caller could create a ClientSocketHandle directly and call
+ // set_socket() on it to set a valid StreamSocket instance.
wtc 2011/08/09 21:21:29 It is fine by me to support creating such a Client
yzshen1 2011/08/09 23:45:29 Do you mean I need to add one in this CL? On 2011
yzshen1 2011/08/12 21:31:39 wtc: the unit test is: scoped_ptr<ClientSocketH
yzshen1 2011/08/13 00:40:34 Done.
virtual SSLClientSocket* CreateSSLClientSocket(
ClientSocketHandle* transport_socket,
const HostPortPair& host_and_port,

Powered by Google App Engine
This is Rietveld 408576698