Implement PPB_Flash_TCPSocket.InitiateSSL.

net/socket/client_socket_factory.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_SOCKET_CLIENT_SOCKET_FACTORY_H_
 #define NET_SOCKET_CLIENT_SOCKET_FACTORY_H_
 #pragma once
 
 #include <string>
 
@@ skipping 29 matching lines @@
       DatagramSocket::BindType bind_type,
       const RandIntCallback& rand_int_cb,
       NetLog* net_log,
       const NetLog::Source& source) = 0;
 
   virtual StreamSocket* CreateTransportClientSocket(
       const AddressList& addresses,
       NetLog* net_log,
       const NetLog::Source& source) = 0;
 
+  // It is allowed to pass in a |transport_socket| that is not obtained from a
+  // socket pool. The caller could create a ClientSocketHandle directly and call
+  // set_socket() on it to set a valid StreamSocket instance.

[wtc, 2011/08/09 21:21:29]

It is fine by me to support creating such a ClientSocketHandle.
We should add a unit test to verify this kind of ClientSocketHandle
can be used by SSLClientSocket successfully.

Right now SSLClientSocketNSS calls only the following
two methods on ClientSocketHandle:

ClientSocketHandle::socket()
ClientSocketHandle destructor

So a simple unit test can be used to test this.

[yzshen1, 2011/08/09 23:45:29]

Do you mean I need to add one in this CL?

On 2011/08/09 21:21:29, wtc wrote:

[yzshen1, 2011/08/12 21:31:39]

wtc: the unit test is:

  scoped_ptr<ClientSocketHandle> socket(new ClientSocketHandle);
  socket.set_socket(...);

  scoped_ptr<ClientSocketHandle> transport(socket.release());

  transport->socket()->Read();  // No need to test these

  // Just verify that such a simple ClientSocketHandle,
  // not associated with any client socket pool, can be]
  // destroyed safely.

[yzshen1, 2011/08/13 00:40:34]

Done.

   virtual SSLClientSocket* CreateSSLClientSocket(
       ClientSocketHandle* transport_socket,
       const HostPortPair& host_and_port,
       const SSLConfig& ssl_config,
       SSLHostInfo* ssl_host_info,
       const SSLClientSocketContext& context) = 0;
 
   // Deprecated function (http://crbug.com/37810) that takes a StreamSocket.
   virtual SSLClientSocket* CreateSSLClientSocket(
       StreamSocket* transport_socket,
       const HostPortPair& host_and_port,
       const SSLConfig& ssl_config,
       SSLHostInfo* ssl_host_info,
       const SSLClientSocketContext& context);
 
   // Clears cache used for SSL session resumption.
   virtual void ClearSSLSessionCache() = 0;
 
   // Returns the default ClientSocketFactory.
   static ClientSocketFactory* GetDefaultFactory();
 
   // Instructs the default ClientSocketFactory to use the system SSL library.
   static void UseSystemSSL();
 };
 
 }  // namespace net
 
 #endif  // NET_SOCKET_CLIENT_SOCKET_FACTORY_H_