Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: webkit/quota/mock_quota_manager_unittest.cc

Issue 7533013: Quota: Add quota::StorageType to the GetOriginsCallback definition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Jochen's nit. Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/quota/mock_quota_manager.cc ('k') | webkit/quota/mock_storage_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/quota/mock_quota_manager_unittest.cc
diff --git a/webkit/quota/mock_quota_manager_unittest.cc b/webkit/quota/mock_quota_manager_unittest.cc
index ee6a10129cde08ade2a0afc17ab22518dad1eb7e..2a4b7ef5f788a81378fec4676f04b567ef465494 100644
--- a/webkit/quota/mock_quota_manager_unittest.cc
+++ b/webkit/quota/mock_quota_manager_unittest.cc
@@ -56,8 +56,9 @@ class MockQuotaManagerTest : public testing::Test {
&MockQuotaManagerTest::GotModifiedOrigins));
}
- void GotModifiedOrigins(const std::set<GURL>& origins) {
+ void GotModifiedOrigins(const std::set<GURL>& origins, StorageType type) {
origins_ = origins;
+ type_ = type;
}
void DeleteOriginData(const GURL& origin, StorageType type) {
@@ -83,6 +84,10 @@ class MockQuotaManagerTest : public testing::Test {
return origins_;
}
+ const StorageType GetType() {
+ return type_;
+ }
+
private:
ScopedTempDir data_dir_;
base::ScopedCallbackFactory<MockQuotaManagerTest> callback_factory_;
@@ -92,6 +97,7 @@ class MockQuotaManagerTest : public testing::Test {
int deletion_callback_count_;
std::set<GURL> origins_;
+ StorageType type_;
DISALLOW_COPY_AND_ASSIGN(MockQuotaManagerTest);
};
@@ -148,6 +154,7 @@ TEST_F(MockQuotaManagerTest, ModifiedOrigins) {
GetModifiedOrigins(kStorageTypeTemporary, then);
MessageLoop::current()->RunAllPending();
+ EXPECT_EQ(kStorageTypeTemporary, GetType());
EXPECT_EQ(1UL, GetOrigins().size());
EXPECT_EQ(1UL, GetOrigins().count(kOrigin1));
EXPECT_EQ(0UL, GetOrigins().count(kOrigin2));
@@ -157,6 +164,7 @@ TEST_F(MockQuotaManagerTest, ModifiedOrigins) {
GetModifiedOrigins(kStorageTypeTemporary, then);
MessageLoop::current()->RunAllPending();
+ EXPECT_EQ(kStorageTypeTemporary, GetType());
EXPECT_EQ(2UL, GetOrigins().size());
EXPECT_EQ(1UL, GetOrigins().count(kOrigin1));
EXPECT_EQ(1UL, GetOrigins().count(kOrigin2));
@@ -164,6 +172,7 @@ TEST_F(MockQuotaManagerTest, ModifiedOrigins) {
GetModifiedOrigins(kStorageTypeTemporary, now - a_minute);
MessageLoop::current()->RunAllPending();
+ EXPECT_EQ(kStorageTypeTemporary, GetType());
EXPECT_EQ(1UL, GetOrigins().size());
EXPECT_EQ(0UL, GetOrigins().count(kOrigin1));
EXPECT_EQ(1UL, GetOrigins().count(kOrigin2));
« no previous file with comments | « webkit/quota/mock_quota_manager.cc ('k') | webkit/quota/mock_storage_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698