Quota: Add quota::StorageType to the GetOriginsCallback definition.

webkit/quota/mock_quota_manager_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 
 #include <set>
 
 #include "base/file_util.h"
 #include "base/memory/scoped_callback_factory.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 38 matching lines @@
     manager_ = NULL;
     MessageLoop::current()->RunAllPending();
   }
 
   void GetModifiedOrigins(StorageType type, base::Time since) {
     manager_->GetOriginsModifiedSince(type, since,
         callback_factory_.NewCallback(
             &MockQuotaManagerTest::GotModifiedOrigins));
   }
 
-  void GotModifiedOrigins(const std::set<GURL>& origins) {
+  void GotModifiedOrigins(const std::set<GURL>& origins, StorageType type) {
     origins_ = origins;
+    type_ = type;
   }
 
   void DeleteOriginData(const GURL& origin, StorageType type) {
     manager_->DeleteOriginData(origin, type,
         callback_factory_.NewCallback(
             &MockQuotaManagerTest::DeletedOriginData));
   }
 
   void DeletedOriginData(QuotaStatusCode status) {
     ++deletion_callback_count_;
     EXPECT_EQ(quota::kQuotaStatusOk, status);
   }
 
   int GetDeletionCallbackCount() {

[kinuko, 2011/08/01 11:16:19]

nit: can all of these getter methods const?

naming-nit: I might name these simple inline getters like:

int deletion_callback_count() const;
MockQuotaManager manager() const;
const std::set<GURL>& origins() const;

http://www.chromium.org/developers/coding-style#TOC-Inline-functions

[Mike West, 2011/08/01 12:55:22]

Done.

     return deletion_callback_count_;
   }
 
   MockQuotaManager* GetManager() {
     return manager_.get();
   }
 
   const std::set<GURL> GetOrigins() {

[kinuko, 2011/08/01 11:16:19]

could this return const std::set<GURL>& (a reference)?

[Mike West, 2011/08/01 12:55:22]

Done.

     return origins_;
   }
 
+  const StorageType GetType() {
+    return type_;
+  }
+
  private:
   ScopedTempDir data_dir_;
   base::ScopedCallbackFactory<MockQuotaManagerTest> callback_factory_;
   scoped_refptr<MockQuotaManager> manager_;
   scoped_refptr<MockSpecialStoragePolicy> policy_;
 
   int deletion_callback_count_;
 
   std::set<GURL> origins_;
+  StorageType type_;
 
   DISALLOW_COPY_AND_ASSIGN(MockQuotaManagerTest);
 };
 
 TEST_F(MockQuotaManagerTest, BasicOriginManipulation) {
   EXPECT_FALSE(GetManager()->OriginHasData(kOrigin1, kStorageTypeTemporary));
   EXPECT_FALSE(GetManager()->OriginHasData(kOrigin2, kStorageTypeTemporary));
   EXPECT_FALSE(GetManager()->OriginHasData(kOrigin1, kStorageTypePersistent));
   EXPECT_FALSE(GetManager()->OriginHasData(kOrigin2, kStorageTypePersistent));
 
@@ skipping 36 matching lines @@
 
   GetModifiedOrigins(kStorageTypeTemporary, then);
   MessageLoop::current()->RunAllPending();
   EXPECT_TRUE(GetOrigins().empty());
 
   GetManager()->AddOrigin(kOrigin1, kStorageTypeTemporary, now - an_hour);
 
   GetModifiedOrigins(kStorageTypeTemporary, then);
   MessageLoop::current()->RunAllPending();
 
+  EXPECT_EQ(kStorageTypeTemporary, GetType());
   EXPECT_EQ(1UL, GetOrigins().size());
   EXPECT_EQ(1UL, GetOrigins().count(kOrigin1));
   EXPECT_EQ(0UL, GetOrigins().count(kOrigin2));
 
   GetManager()->AddOrigin(kOrigin2, kStorageTypeTemporary, now);
 
   GetModifiedOrigins(kStorageTypeTemporary, then);
   MessageLoop::current()->RunAllPending();
 
+  EXPECT_EQ(kStorageTypeTemporary, GetType());
   EXPECT_EQ(2UL, GetOrigins().size());
   EXPECT_EQ(1UL, GetOrigins().count(kOrigin1));
   EXPECT_EQ(1UL, GetOrigins().count(kOrigin2));
 
   GetModifiedOrigins(kStorageTypeTemporary, now - a_minute);
   MessageLoop::current()->RunAllPending();
 
+  EXPECT_EQ(kStorageTypeTemporary, GetType());
   EXPECT_EQ(1UL, GetOrigins().size());
   EXPECT_EQ(0UL, GetOrigins().count(kOrigin1));
   EXPECT_EQ(1UL, GetOrigins().count(kOrigin2));
 }
 }  // Namespace quota