Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 7533013: Quota: Add quota::StorageType to the GetOriginsCallback definition. (Closed)

Created:
9 years, 4 months ago by Mike West
Modified:
9 years, 4 months ago
CC:
chromium-reviews, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr., kinuko+watch
Visibility:
Public.

Description

Quota: Add quota::StorageType to the GetOriginsCallback definition. BUG=90996 TEST=test_shell_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95591

Patch Set 1 #

Total comments: 4

Patch Set 2 : Missed IndexedDbQuotaClient. #

Total comments: 2

Patch Set 3 : Indentation. #

Patch Set 4 : Rebasing on top of http://crbug.com/63700 #

Total comments: 2

Patch Set 5 : Jochen's nit. #

Total comments: 4

Patch Set 6 : Kinuko's nits. #

Patch Set 7 : Rebasing onto today's ToT. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+188 lines, -145 lines) Patch
M chrome/browser/browsing_data_remover.h View 1 2 3 4 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/browser/browsing_data_remover.cc View 1 2 3 3 chunks +7 lines, -28 lines 0 comments Download
M content/browser/in_process_webkit/indexed_db_quota_client.h View 1 1 chunk +9 lines, -6 lines 0 comments Download
M content/browser/in_process_webkit/indexed_db_quota_client.cc View 1 7 chunks +25 lines, -14 lines 0 comments Download
M content/browser/in_process_webkit/indexed_db_quota_client_unittest.cc View 1 2 3 4 5 6 3 chunks +6 lines, -1 line 0 comments Download
M webkit/appcache/appcache_quota_client.cc View 5 chunks +6 lines, -5 lines 0 comments Download
M webkit/appcache/appcache_quota_client_unittest.cc View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M webkit/database/database_quota_client.h View 1 2 1 chunk +10 lines, -7 lines 0 comments Download
M webkit/database/database_quota_client.cc View 7 chunks +24 lines, -14 lines 0 comments Download
M webkit/database/database_quota_client_unittest.cc View 2 chunks +4 lines, -1 line 0 comments Download
M webkit/fileapi/file_system_quota_client.h View 1 chunk +6 lines, -4 lines 0 comments Download
M webkit/fileapi/file_system_quota_client.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M webkit/fileapi/file_system_quota_client_unittest.cc View 2 chunks +4 lines, -1 line 0 comments Download
M webkit/quota/mock_quota_manager.cc View 1 2 3 2 chunks +6 lines, -3 lines 0 comments Download
M webkit/quota/mock_quota_manager_unittest.cc View 1 2 3 4 5 4 chunks +52 lines, -43 lines 0 comments Download
M webkit/quota/mock_storage_client.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/quota/quota_client.h View 1 chunk +2 lines, -1 line 0 comments Download
M webkit/quota/quota_manager.cc View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/quota/quota_manager_unittest.cc View 8 chunks +9 lines, -1 line 0 comments Download
M webkit/quota/quota_types.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/quota/usage_tracker.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
Mike West
Hi Kinuko, Michael, This is a first pass at adding `quota::StorageType` to the `GetOriginsCallback` definition. ...
9 years, 4 months ago (2011-07-29 09:52:45 UTC) #1
kinuko
lgtm http://codereview.chromium.org/7533013/diff/1/webkit/appcache/appcache_quota_client_unittest.cc File webkit/appcache/appcache_quota_client_unittest.cc (right): http://codereview.chromium.org/7533013/diff/1/webkit/appcache/appcache_quota_client_unittest.cc#newcode141 webkit/appcache/appcache_quota_client_unittest.cc:141: quota::StorageType type) { nit: indent either one of ...
9 years, 4 months ago (2011-07-29 11:12:36 UTC) #2
kinuko
http://codereview.chromium.org/7533013/diff/2001/webkit/quota/quota_client.h File webkit/quota/quota_client.h (right): http://codereview.chromium.org/7533013/diff/2001/webkit/quota/quota_client.h#newcode62 webkit/quota/quota_client.h:62: GetOriginsCallback* callback) = 0; On 2011/07/29 11:12:37, kinuko wrote: ...
9 years, 4 months ago (2011-07-29 12:13:15 UTC) #3
Mike West
Thanks! http://codereview.chromium.org/7533013/diff/1/webkit/appcache/appcache_quota_client_unittest.cc File webkit/appcache/appcache_quota_client_unittest.cc (right): http://codereview.chromium.org/7533013/diff/1/webkit/appcache/appcache_quota_client_unittest.cc#newcode141 webkit/appcache/appcache_quota_client_unittest.cc:141: quota::StorageType type) { On 2011/07/29 11:12:36, kinuko wrote: ...
9 years, 4 months ago (2011-07-29 12:25:42 UTC) #4
Mike West
Kinuko, can you take another look at this? I've rebased it on top of the ...
9 years, 4 months ago (2011-08-01 09:37:49 UTC) #5
jochen (gone - plz use gerrit)
LGTM with my comment addressed http://codereview.chromium.org/7533013/diff/7001/chrome/browser/browsing_data_remover.h File chrome/browser/browsing_data_remover.h (right): http://codereview.chromium.org/7533013/diff/7001/chrome/browser/browsing_data_remover.h#newcode154 chrome/browser/browsing_data_remover.h:154: void OnGotQuotaManagedOrigins(const std::set<GURL>&, quota::StorageType); ...
9 years, 4 months ago (2011-08-01 09:44:56 UTC) #6
Mike West
Thanks Jochen. http://codereview.chromium.org/7533013/diff/7001/chrome/browser/browsing_data_remover.h File chrome/browser/browsing_data_remover.h (right): http://codereview.chromium.org/7533013/diff/7001/chrome/browser/browsing_data_remover.h#newcode154 chrome/browser/browsing_data_remover.h:154: void OnGotQuotaManagedOrigins(const std::set<GURL>&, quota::StorageType); On 2011/08/01 09:44:56, ...
9 years, 4 months ago (2011-08-01 09:47:40 UTC) #7
kinuko
lgtm except for nits. Thanks! http://codereview.chromium.org/7533013/diff/10002/webkit/quota/mock_quota_manager_unittest.cc File webkit/quota/mock_quota_manager_unittest.cc (right): http://codereview.chromium.org/7533013/diff/10002/webkit/quota/mock_quota_manager_unittest.cc#newcode75 webkit/quota/mock_quota_manager_unittest.cc:75: int GetDeletionCallbackCount() { nit: ...
9 years, 4 months ago (2011-08-01 11:16:19 UTC) #8
Mike West
Thanks Kinuko! http://codereview.chromium.org/7533013/diff/10002/webkit/quota/mock_quota_manager_unittest.cc File webkit/quota/mock_quota_manager_unittest.cc (right): http://codereview.chromium.org/7533013/diff/10002/webkit/quota/mock_quota_manager_unittest.cc#newcode75 webkit/quota/mock_quota_manager_unittest.cc:75: int GetDeletionCallbackCount() { On 2011/08/01 11:16:19, kinuko ...
9 years, 4 months ago (2011-08-01 12:55:22 UTC) #9
commit-bot: I haz the power
Presubmit check for 7533013-7025 failed and returned exit status 1. Running presubmit commit checks ...
9 years, 4 months ago (2011-08-02 07:34:45 UTC) #10
Mike West
On 2011/08/02 07:34:45, I haz the power (commit-bot) wrote: > ** Presubmit ERRORS ** > ...
9 years, 4 months ago (2011-08-02 09:02:44 UTC) #11
michaeln
LGTM > Missing LGTM from an OWNER for: > Good morning michaeln! Can you take ...
9 years, 4 months ago (2011-08-02 18:01:01 UTC) #12
commit-bot: I haz the power
9 years, 4 months ago (2011-08-05 08:39:56 UTC) #13
Change committed as 95591

Powered by Google App Engine
This is Rietveld 408576698