Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Unified Diff: ppapi/shared_impl/graphics_3d_impl.cc

Issue 7530010: Added PPB_Graphics3D_Dev::Resize to let plugins resize the backing surface. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/shared_impl/graphics_3d_impl.cc
===================================================================
--- ppapi/shared_impl/graphics_3d_impl.cc (revision 94518)
+++ ppapi/shared_impl/graphics_3d_impl.cc (working copy)
@@ -33,6 +33,15 @@
return PP_ERROR_FAILED;
}
+int32_t Graphics3DImpl::Resize(int32_t width, int32_t height) {
+ if ((width < 0) || (height < 0))
+ return PP_ERROR_BADARGUMENT;
+
+ gles2_impl()->ResizeCHROMIUM(width, height);
piman 2011/07/28 23:35:06 You won't have a gles2_impl in the out-of-process
alokp 2011/07/29 16:13:12 In that case this command will be handled by the p
+ // TODO(alokp): Check if resize succeeded and return appropriate error code.
apatrick_chromium 2011/07/28 22:11:26 You might want to Flush after ResizeCHROMIUM so th
alokp 2011/07/28 22:40:12 Glad that you mentioned. All demos except stencil-
piman 2011/07/28 23:35:06 I don't think a Flush is necessary since ResizeChr
+ return PP_OK;
+}
+
int32_t Graphics3DImpl::SwapBuffers(PP_CompletionCallback callback) {
if (!callback.func) {
// Blocking SwapBuffers isn't supported (since we have to be on the main

Powered by Google App Engine
This is Rietveld 408576698