Added PPB_Graphics3D_Dev::Resize to let plugins resize the backing surface.

ppapi/shared_impl/graphics_3d_impl.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ppapi/shared_impl/graphics_3d_impl.h"
 
 #include "base/logging.h"
 #include "gpu/command_buffer/client/gles2_cmd_helper.h"
 #include "gpu/command_buffer/client/gles2_implementation.h"
 #include "ppapi/c/pp_errors.h"
@@ skipping 15 matching lines @@
 int32_t Graphics3DImpl::GetAttribs(int32_t* attrib_list) {
   // TODO(alokp): Implement me.
   return PP_ERROR_FAILED;
 }
 
 int32_t Graphics3DImpl::SetAttribs(int32_t* attrib_list) {
   // TODO(alokp): Implement me.
   return PP_ERROR_FAILED;
 }
 
+int32_t Graphics3DImpl::Resize(int32_t width, int32_t height) {
+  if ((width < 0) || (height < 0))
+    return PP_ERROR_BADARGUMENT;
+
+  gles2_impl()->ResizeCHROMIUM(width, height);

[piman, 2011/07/28 23:35:06]

You won't have a gles2_impl in the out-of-process case

[alokp, 2011/07/29 16:13:12]

In that case this command will be handled by the proxy which shares this
implementation. We have to check for the availability of gles2_impl only in
swap-buffers because the proxy delegates some of the task to the host. This is
not the case here.

+  // TODO(alokp): Check if resize succeeded and return appropriate error code.

[apatrick_chromium, 2011/07/28 22:11:26]

You might want to Flush after ResizeCHROMIUM so that subsequent IPCs don't race
ahead of it. I'm not familiar with this code though... piman will know.

[alokp, 2011/07/28 22:40:12]

Glad that you mentioned. All demos except stencil-test is working fine with this
patch. But stencil test is only producing a green quad that spans the whole
viewport. It is supposed to draw four quads. The exe version of stencil test
works. Commenting out the resize calls in pepper.cc works (although stretched).
I have tried adding flush everywhere without much success. It also randomly
crashes in ANGLE. It may be just specific to the stencil buffer.

[piman, 2011/07/28 23:35:06]

I don't think a Flush is necessary since ResizeChromium goes through command
buffers.

+  return PP_OK;
+}
+
 int32_t Graphics3DImpl::SwapBuffers(PP_CompletionCallback callback) {
   if (!callback.func) {
     // Blocking SwapBuffers isn't supported (since we have to be on the main
     // thread).
     return PP_ERROR_BADARGUMENT;
   }
 
   if (HasPendingSwap()) {
     // Already a pending SwapBuffers that hasn't returned yet.
     return PP_ERROR_INPROGRESS;
@@ skipping 50 matching lines @@
     DCHECK(command_buffer);
     command_buffer->DestroyTransferBuffer(transfer_buffer_id_);
     transfer_buffer_id_ = -1;
   }
 
   gles2_helper_.reset();
 }
 
 }  // namespace ppapi