Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 7530008: Add --gpu-no-context-lost commandline switch. (Closed)

Created:
9 years, 4 months ago by Zhenyao Mo
Modified:
9 years, 4 months ago
Reviewers:
apatrick_chromium
CC:
chromium-reviews, joi+watch-content_chromium.org, jam, apatrick_chromium, piman
Visibility:
Public.

Description

Add --gpu-no-context-lost commandline switch. At the moment chrome users with GLES backend do not have accelerated 2d canvas if a graphics context could be lost. Unfortunately we don't have a way to know if a GLES backend does or does not lose context in situations like entering power saving mode, screen saving mode, etc. This switch basically tells chrome the backend does not lose context, thus, enable accelerated 2d canvas. BUG=90464 TEST=bots green, passing this switch with GLES backend enables accelerated 2d canvas Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=94548

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -10 lines) Patch
M content/browser/gpu/gpu_process_host.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M content/gpu/gpu_info_collector_linux.cc View 3 chunks +12 lines, -4 lines 0 comments Download
M ui/gfx/gl/gl_switches.h View 1 chunk +2 lines, -1 line 0 comments Download
M ui/gfx/gl/gl_switches.cc View 2 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Zhenyao Mo
Please review.
9 years, 4 months ago (2011-07-28 20:35:02 UTC) #1
apatrick_chromium
9 years, 4 months ago (2011-07-28 20:58:47 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698