Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 7529015: Allow the renderer process to map textures from one context into another. (Closed)

Created:
9 years, 4 months ago by apatrick_chromium
Modified:
9 years, 4 months ago
Reviewers:
jamesr
CC:
chromium-reviews, joi+watch-content_chromium.org, jam, apatrick_chromium
Visibility:
Public.

Description

Allow the renderer process to map textures from one context into another. This is on an individual resource basis rather than general share groups in order to hide be able to hide the full namespace from untrusted plugins. Accelerated 2D canvas now no longer needs to copy its backing store on every page composite and the redundant backing texture is not needed, saving video memory. Unit tests for the GPU service to follow. Patch to delete copyTextureToParentTexture extensions from gpu/ to follow. BUG=90714 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=94743

Patch Set 1 : '' #

Patch Set 2 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+274 lines, -81 lines) Patch
M content/common/gpu/gpu_command_buffer_stub.h View 1 2 chunks +5 lines, -0 lines 0 comments Download
M content/common/gpu/gpu_command_buffer_stub.cc View 1 2 chunks +18 lines, -0 lines 1 comment Download
M content/common/gpu/gpu_messages.h View 1 2 chunks +23 lines, -0 lines 0 comments Download
M content/renderer/gpu/command_buffer_proxy.h View 1 2 chunks +6 lines, -0 lines 0 comments Download
M content/renderer/gpu/command_buffer_proxy.cc View 1 1 chunk +21 lines, -0 lines 0 comments Download
M content/renderer/gpu/renderer_gl_context.h View 1 2 chunks +29 lines, -0 lines 0 comments Download
M content/renderer/gpu/renderer_gl_context.cc View 1 2 chunks +37 lines, -32 lines 0 comments Download
M content/renderer/gpu/webgraphicscontext3d_command_buffer_impl.cc View 1 1 chunk +4 lines, -1 line 0 comments Download
M gpu/command_buffer/common/constants.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.h View 1 2 chunks +21 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 5 chunks +46 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_mock.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gpu_scheduler.h View 1 2 chunks +6 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gpu_scheduler.cc View 1 1 chunk +12 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/texture_manager.h View 1 7 chunks +16 lines, -10 lines 0 comments Download
M gpu/command_buffer/service/texture_manager.cc View 1 3 chunks +19 lines, -12 lines 0 comments Download
M gpu/command_buffer/service/texture_manager_unittest.cc View 1 1 chunk +0 lines, -22 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
apatrick_chromium
9 years, 4 months ago (2011-07-29 18:00:58 UTC) #1
jamesr
9 years, 4 months ago (2011-07-29 19:55:07 UTC) #2
Awesome! LGTM.

http://codereview.chromium.org/7529015/diff/7004/content/common/gpu/gpu_comma...
File content/common/gpu/gpu_command_buffer_stub.cc (right):

http://codereview.chromium.org/7529015/diff/7004/content/common/gpu/gpu_comma...
content/common/gpu/gpu_command_buffer_stub.cc:251: 
nit: extra newline

Powered by Google App Engine
This is Rietveld 408576698