Eliminate a warning in a failure case.

Eliminate a warning in a failure case.

BUG=chromium:92568
TEST=not yet

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96776

[Ken Russell (switch to Gerrit), 2011-08-03 19:51:08]

Generally looks good, but the generator script needs to be run, glapitemp.h
needs to be included in this patch, and the patch and README.chromium need to be
updated.

[Peter Mayo, 2011-08-12 00:35:57]

On 2011/08/03 19:51:08, kbr wrote:
> Generally looks good, but the generator script needs to be run, glapitemp.h
> needs to be included in this patch, and the patch and README.chromium need to
be
> updated.

So this first cut changes the warning to "warning: cast to pointer from integer
of different size" ... since it is taking the int return type of the
NoOpGeneric.  More work.

[Ken Russell (switch to Gerrit), 2011-08-12 01:06:38]

On 2011/08/12 00:35:57, Peter Mayo wrote:
> On 2011/08/03 19:51:08, kbr wrote:
> > Generally looks good, but the generator script needs to be run, glapitemp.h
> > needs to be included in this patch, and the patch and README.chromium need
to
> be
> > updated.
> 
> So this first cut changes the warning to "warning: cast to pointer from
integer
> of different size" ... since it is taking the int return type of the
> NoOpGeneric.  More work.

Would it work to just define RETURN_DISPATCH as "return
(type)(intptr_t)NoOpGeneric()" in glapi_nop.c? Or would that break some
non-pointer return types?

This looks good to me otherwise.

[Peter Mayo (wrong one), 2011-08-12 01:23:07]

That makes the integer return types have the inverse complaint.

MesaLib/src/mapi/glapi/glapitemp.h: In function ?NoOpIsEnabledIndexedEXT?:
MesaLib/src/mapi/glapi/glapitemp.h:5624: warning: cast from pointer to
integer of different size
MesaLib/src/mapi/glapi/glapitemp.h: In function ?NoOpObjectPurgeableAPPLE?:
MesaLib/src/mapi/glapi/glapitemp.h:5733: warning: cast from pointer to
integer of different size

There is an is_pointer test for the argument types in the generator python,
but the return type is a string, not a type like the parameters.

And 1 of the pointer return types doesn't end with a * in the text.

I think I can get it hammered down by not using the return of the function
though.

Peter.

On Thu, Aug 11, 2011 at 9:06 PM, <kbr@chromium.org> wrote:

> On 2011/08/12 00:35:57, Peter Mayo wrote:
>
>> On 2011/08/03 19:51:08, kbr wrote:
>> > Generally looks good, but the generator script needs to be run,
>> glapitemp.h
>> > needs to be included in this patch, and the patch and README.chromium
>> need
>>
> to
>
>> be
>> > updated.
>>
>
>  So this first cut changes the warning to "warning: cast to pointer from
>>
> integer
>
>> of different size" ... since it is taking the int return type of the
>> NoOpGeneric.  More work.
>>
>
> Would it work to just define RETURN_DISPATCH as "return
> (type)(intptr_t)NoOpGeneric()" in glapi_nop.c? Or would that break some
> non-pointer return types?
>
> This looks good to me otherwise.
>
>
>
>
http://codereview.chromium.**org/7523033/<http://codereview.chromium.org/7523...
>



-- 

Peter Mayo | Tangent | petermayo@google.com | 519-880-3439

[Peter Mayo, 2011-08-12 01:32:50]

Try job is underway.

Please take another look.

[Ken Russell (switch to Gerrit), 2011-08-12 21:17:40]

LGTM. Very nice.

[commit-bot: I haz the power, 2011-08-15 15:03:13]

Change committed as 96776