Issue 7520021: Revert 94426 - Removed wchat_t from Time::FromString.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7520021: Revert 94426 - Removed wchat_t from Time::FromString. (Closed)

Created:
9 years, 5 months ago by gmorrita

Modified:
9 years, 5 months ago

Reviewers:
shinyak (Google)

CC:
chromium-reviews, kinuko+watch, brettw-cc_chromium.org, darin-cc_chromium.org, cbentzel+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Revert 94426 - Removed wchat_t from Time::FromString. Also, some of the test case are moved for pr_time_unittests to time_unitests. BUG=77962 TEST=base_unittests:TimeTest.* Review URL: http://codereview.chromium.org/7470038 TBR=shinyak@google.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=94427

Created: 9 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+157 lines, -242 lines)			Patch
M	base/file_util_unittest.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	base/metrics/field_trial.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	base/pr_time_unittest.cc	View	2 chunks	+117 lines, -1 line	0 comments	Download
M	base/third_party/nspr/prtime.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	base/time.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	base/time.cc	View	2 chunks	+5 lines, -7 lines	0 comments	Download
M	base/time_unittest.cc	View	7 chunks	+7 lines, -212 lines	0 comments	Download
M	chrome/browser/web_resource/promo_resource_service.cc	View	2 chunks	+8 lines, -4 lines	0 comments	Download
M	chrome/common/metrics_helpers.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/ftp/ftp_util_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/http/http_response_headers.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	net/http/http_response_headers_unittest.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	webkit/blob/blob_storage_controller_unittest.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	webkit/fileapi/file_system_dir_url_request_job_unittest.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download

Total messages: 1 (0 generated)