Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 7470038: Removed wchat_t from Time::FromString. (Closed)

Created:
9 years, 5 months ago by shinyak (Google)
Modified:
9 years, 4 months ago
Reviewers:
kinuko, brettw, wtc
CC:
chromium-reviews, cbentzel+watch_chromium.org, brettw-cc_chromium.org, darin-cc_chromium.org, kinuko+watch, Paweł Hajdan Jr.
Visibility:
Public.

Description

Removed wchat_t from Time::FromString. Also, some of the test case are moved for pr_time_unittests to time_unitests. BUG=77962 TEST=base_unittests:TimeTest.* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=94426

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+242 lines, -157 lines) Patch
M base/file_util_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/metrics/field_trial.cc View 1 chunk +1 line, -2 lines 0 comments Download
M base/pr_time_unittest.cc View 2 chunks +1 line, -117 lines 0 comments Download
M base/third_party/nspr/prtime.h View 1 chunk +1 line, -1 line 0 comments Download
M base/time.h View 1 chunk +1 line, -1 line 0 comments Download
M base/time.cc View 2 chunks +7 lines, -5 lines 0 comments Download
M base/time_unittest.cc View 7 chunks +212 lines, -7 lines 0 comments Download
M chrome/browser/web_resource/promo_resource_service.cc View 2 chunks +4 lines, -8 lines 0 comments Download
M chrome/common/metrics_helpers.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/ftp/ftp_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_response_headers.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/http/http_response_headers_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M webkit/blob/blob_storage_controller_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M webkit/fileapi/file_system_dir_url_request_job_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
shinyak (Google)
brettw, wtc, kinuko I've moved http://codereview.chromium.org/6903022/ to this issue because commit queue cannot be used. ...
9 years, 5 months ago (2011-07-27 07:18:59 UTC) #1
kinuko
lgtm On 2011/07/27 07:18:59, shinyak wrote: > brettw, wtc, kinuko > > I've moved http://codereview.chromium.org/6903022/ ...
9 years, 5 months ago (2011-07-27 07:53:43 UTC) #2
kinuko
for webkit/{blob,fileapi} changes. On 2011/07/27 07:53:43, kinuko wrote: > lgtm > > On 2011/07/27 07:18:59, ...
9 years, 5 months ago (2011-07-27 07:53:57 UTC) #3
brettw
LGTM
9 years, 5 months ago (2011-07-27 15:45:12 UTC) #4
wtc
LGTM.
9 years, 5 months ago (2011-07-27 16:25:42 UTC) #5
commit-bot: I haz the power
9 years, 4 months ago (2011-07-28 04:53:26 UTC) #6
Change committed as 94426

Powered by Google App Engine
This is Rietveld 408576698