Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(795)

Unified Diff: chrome/browser/extensions/extension_webstore_private_browsertest.cc

Issue 7511028: Added logging to ExtensionWebstorePrivateBrowserTest.BrowserLogin (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_webstore_private_browsertest.cc
diff --git a/chrome/browser/extensions/extension_webstore_private_browsertest.cc b/chrome/browser/extensions/extension_webstore_private_browsertest.cc
index 024c2695d4032cd1e3b7f5843bab796cf6dc6ac4..a82a41c8d87cf92dd4f423ed7063e62108a5057d 100644
--- a/chrome/browser/extensions/extension_webstore_private_browsertest.cc
+++ b/chrome/browser/extensions/extension_webstore_private_browsertest.cc
@@ -181,17 +181,26 @@ class ExtensionWebstorePrivateBrowserTest : public ExtensionBrowserTest {
std::string test_url_base_;
};
+// TODO(asargent) I've added some extra logging to this test since we've seen a
+// few failures on the bots lately. See crbug.com/91753 for details.
IN_PROC_BROWSER_TEST_F(ExtensionWebstorePrivateBrowserTest, BrowserLogin) {
+ LOG(INFO) << "Adding rule to host resolver";
host_resolver()->AddRule(kTestUrlHostname, "127.0.0.1");
+
+ LOG(INFO) << "Starting test server";
ASSERT_TRUE(test_server()->Start());
+ LOG(INFO) << "expect_nonempty.html";
RunLoginTest("browser_login/expect_nonempty.html",
"foo@bar.com", false, "");
+ LOG(INFO) << "prompt_no_preferred.html";
RunLoginTest("browser_login/prompt_no_preferred.html", "", true, "");
+ LOG(INFO) << "prompt_preferred.html";
RunLoginTest("browser_login/prompt_preferred.html", "", true, "foo@bar.com");
+ LOG(INFO) << "prompt_login_fails.html";
RunLoginTest("browser_login/prompt_login_fails.html",
"", false, "foo@bar.com");
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698