Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Side by Side Diff: chrome/browser/extensions/extension_webstore_private_browsertest.cc

Issue 7511028: Added logging to ExtensionWebstorePrivateBrowserTest.BrowserLogin (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/string_number_conversions.h" 5 #include "base/string_number_conversions.h"
6 #include "base/utf_string_conversions.h" 6 #include "base/utf_string_conversions.h"
7 #include "chrome/browser/browser_process.h" 7 #include "chrome/browser/browser_process.h"
8 #include "chrome/browser/browser_signin.h" 8 #include "chrome/browser/browser_signin.h"
9 #include "chrome/browser/extensions/extension_browsertest.h" 9 #include "chrome/browser/extensions/extension_browsertest.h"
10 #include "chrome/browser/extensions/extension_test_message_listener.h" 10 #include "chrome/browser/extensions/extension_test_message_listener.h"
(...skipping 163 matching lines...) Expand 10 before | Expand all | Expand 10 after
174 relative_path, 174 relative_path,
175 initial_login, 175 initial_login,
176 login_succeeds, 176 login_succeeds,
177 login_result); 177 login_result);
178 } 178 }
179 179
180 protected: 180 protected:
181 std::string test_url_base_; 181 std::string test_url_base_;
182 }; 182 };
183 183
184 // TODO(asargent) I've added some extra logging to this test since we've seen a
185 // few failures on the bots lately. See crbug.com/91753 for details.
184 IN_PROC_BROWSER_TEST_F(ExtensionWebstorePrivateBrowserTest, BrowserLogin) { 186 IN_PROC_BROWSER_TEST_F(ExtensionWebstorePrivateBrowserTest, BrowserLogin) {
187 LOG(INFO) << "Adding rule to host resolver";
185 host_resolver()->AddRule(kTestUrlHostname, "127.0.0.1"); 188 host_resolver()->AddRule(kTestUrlHostname, "127.0.0.1");
189
190 LOG(INFO) << "Starting test server";
186 ASSERT_TRUE(test_server()->Start()); 191 ASSERT_TRUE(test_server()->Start());
187 192
193 LOG(INFO) << "expect_nonempty.html";
188 RunLoginTest("browser_login/expect_nonempty.html", 194 RunLoginTest("browser_login/expect_nonempty.html",
189 "foo@bar.com", false, ""); 195 "foo@bar.com", false, "");
190 196
197 LOG(INFO) << "prompt_no_preferred.html";
191 RunLoginTest("browser_login/prompt_no_preferred.html", "", true, ""); 198 RunLoginTest("browser_login/prompt_no_preferred.html", "", true, "");
192 199
200 LOG(INFO) << "prompt_preferred.html";
193 RunLoginTest("browser_login/prompt_preferred.html", "", true, "foo@bar.com"); 201 RunLoginTest("browser_login/prompt_preferred.html", "", true, "foo@bar.com");
194 202
203 LOG(INFO) << "prompt_login_fails.html";
195 RunLoginTest("browser_login/prompt_login_fails.html", 204 RunLoginTest("browser_login/prompt_login_fails.html",
196 "", false, "foo@bar.com"); 205 "", false, "foo@bar.com");
197 } 206 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698