[Sync] [Mac] Show sync menu item in app menu even in incognito mode

[Sync] [Mac] Show sync menu item in app menu even in incognito mode

BUG=91682
TEST=Open Chrome, open incognito window, check app menu to make sure there is an item for sync


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95568

[akalin, 2011-08-04 21:39:13]

+shess for review

[Scott Hess - ex-Googler, 2011-08-04 22:28:20]

Generally LGTM, with one nit.

http://codereview.chromium.org/7511024/diff/1/chrome/browser/ui/cocoa/browser...
File chrome/browser/ui/cocoa/browser_window_controller.mm (right):

http://codereview.chromium.org/7511024/diff/1/chrome/browser/ui/cocoa/browser...
chrome/browser/ui/cocoa/browser_window_controller.mm:1030:
sync_ui_util::UpdateSyncItem(item, enable, original_profile);
The only other place UpdateSyncItem() is called from is in
app_controller_mac.mm.  AFAICT my other fix will handle it, but I can't think of
any reason not to push the GetOriginalProfile() and IsSyncAccessible() calls
down into UpdateSyncItem().

[akalin, 2011-08-05 00:32:52]

On 2011/08/04 22:28:20, shess wrote:
> Generally LGTM, with one nit.
> 
>
http://codereview.chromium.org/7511024/diff/1/chrome/browser/ui/cocoa/browser...
> File chrome/browser/ui/cocoa/browser_window_controller.mm (right):
> 
>
http://codereview.chromium.org/7511024/diff/1/chrome/browser/ui/cocoa/browser...
> chrome/browser/ui/cocoa/browser_window_controller.mm:1030:
> sync_ui_util::UpdateSyncItem(item, enable, original_profile);
> The only other place UpdateSyncItem() is called from is in
> app_controller_mac.mm.  AFAICT my other fix will handle it, but I can't think
of
> any reason not to push the GetOriginalProfile() and IsSyncAccessible() calls
> down into UpdateSyncItem().

Okay.  I'll handle that in a separate CL.

[commit-bot: I haz the power, 2011-08-05 04:03:41]

Change committed as 95568