[Sync] [Mac] Show sync menu item in app menu even in incognito mode

chrome/browser/ui/cocoa/browser_window_controller.mm

Index: chrome/browser/ui/cocoa/browser_window_controller.mm
diff --git a/chrome/browser/ui/cocoa/browser_window_controller.mm b/chrome/browser/ui/cocoa/browser_window_controller.mm
index 6df4d70f2622ae63fd30ad400b4c6f103a8af8ca..4eeabcd0536843942b2115a5230a5fbc5c60ebab 100644
--- a/chrome/browser/ui/cocoa/browser_window_controller.mm
+++ b/chrome/browser/ui/cocoa/browser_window_controller.mm
@@ -1023,10 +1023,13 @@ typedef NSInteger NSWindowAnimationBehavior;
           }
           break;
         }
-        case IDC_SYNC_BOOKMARKS:
-          enable &= browser_->profile()->IsSyncAccessible();
-          sync_ui_util::UpdateSyncItem(item, enable, browser_->profile());
+        case IDC_SYNC_BOOKMARKS: {
+          Profile* original_profile =
+              browser_->profile()->GetOriginalProfile();
+          enable &= original_profile->IsSyncAccessible();
+          sync_ui_util::UpdateSyncItem(item, enable, original_profile);

[Scott Hess - ex-Googler, 2011/08/04 22:28:20]

The only other place UpdateSyncItem() is called from is in
app_controller_mac.mm.  AFAICT my other fix will handle it, but I can't think of
any reason not to push the GetOriginalProfile() and IsSyncAccessible() calls
down into UpdateSyncItem().

           break;
+        }
         default:
           // Special handling for the contents of the Text Encoding submenu. On
           // Mac OS, instead of enabling/disabling the top-level menu item, we