Add test to each OptionsPage to open that page

Add test to each OptionsPage to open that page.

Browse to the page and test that the url is correct for the page.

R=jhawkins@chromium.org
BUG=90420
TEST=browser_tests --gtest_filter=*OptionsWebUITest.*


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107017

[James Hawkins, 2011-07-26 01:26:24]

http://codereview.chromium.org/7501004/diff/2001/chrome/chrome_tests.gypi
File chrome/chrome_tests.gypi (right):

http://codereview.chromium.org/7501004/diff/2001/chrome/chrome_tests.gypi#new...
chrome/chrome_tests.gypi:2622: 'test/data/webui/options.js',
mkdir test/data/webui/options

[Sheridan Rawlins, 2011-07-26 01:37:17]

http://codereview.chromium.org/7501004/diff/2001/chrome/chrome_tests.gypi
File chrome/chrome_tests.gypi (right):

http://codereview.chromium.org/7501004/diff/2001/chrome/chrome_tests.gypi#new...
chrome/chrome_tests.gypi:2622: 'test/data/webui/options.js',
I can do that, but, know that the generated file wouldn't have options/ in it as
there's no way to get the dirname in the rule (see
http://code.google.com/p/gyp/issues/detail?id=200).
The right thing might be doable by refactoring things under options/ to a
separate rule/library and linking against it but it seems extreme for something
that a gyp fix can solve.  I can take a look at the gyp patch and offer it up
for commit, but I think it's be higher priority to tackle http://crbug.com/87362
than shaving this yak.

-SCR

On 2011/07/26 01:26:24, James Hawkins wrote:
> mkdir test/data/webui/options

[Sheridan Rawlins, 2011-08-03 16:06:42]

http://codereview.chromium.org/7501004/diff/2001/chrome/chrome_tests.gypi
File chrome/chrome_tests.gypi (right):

http://codereview.chromium.org/7501004/diff/2001/chrome/chrome_tests.gypi#new...
chrome/chrome_tests.gypi:2622: 'test/data/webui/options.js',
On 2011/07/26 01:26:24, James Hawkins wrote:
> mkdir test/data/webui/options

Can this wait until crbug.com/90907 is addressed (to allow source files to be in
any directory for the generation rule)?

[James Hawkins, 2011-08-03 17:32:27]

On 2011/08/03 16:06:42, Sheridan Rawlins wrote:
> http://codereview.chromium.org/7501004/diff/2001/chrome/chrome_tests.gypi
> File chrome/chrome_tests.gypi (right):
> 
>
http://codereview.chromium.org/7501004/diff/2001/chrome/chrome_tests.gypi#new...
> chrome/chrome_tests.gypi:2622: 'test/data/webui/options.js',
> On 2011/07/26 01:26:24, James Hawkins wrote:
> > mkdir test/data/webui/options
> 
> Can this wait until crbug.com/90907 is addressed (to allow source files to be
in
> any directory for the generation rule)?

I'd rather this CL wait for that bug to be addressed.  Also, we've talked
off-line since then and recognized that the JS test files should actually be in
the same directory as the JS implementations.

[Sheridan Rawlins, 2011-08-03 17:55:58]

On 2011/08/03 17:32:27, James Hawkins wrote:
> On 2011/08/03 16:06:42, Sheridan Rawlins wrote:
> > Can this wait until crbug.com/90907 is addressed?
> 
> I'd rather this CL wait for that bug to be addressed.  Also, we've talked
> off-line since then and recognized that the JS test files should actually be
in
> the same directory as the JS implementations.

SGTM - thanks.

[James Hawkins, 2011-09-20 00:49:38]

What is the status of this CL?

[Sheridan Rawlins, 2011-09-20 01:13:44]

It's got all the tests split out, but they're all under
chrome/test/data/webui and we decided to wait for gyp:200 to be able to move
them next to their c++ counter parts.  I got about 1/2 - 2/3 of the way
through (Mac + Linux, but not Windows or Ninja).  My Windows cygwin system
got clobbered & I'm still trying to perform a full gclient sync on Windows
after fixing with the steps in
http://yosanai.com/cygwin-unable-remap-dll-same-address-parent

-SCR

On Mon, Sep 19, 2011 at 5:49 PM, <jhawkins@chromium.org> wrote:

> What is the status of this CL?
>
>
http://codereview.chromium.**org/7501004/<http://codereview.chromium.org/7501...
>

[Sheridan Rawlins, 2011-10-22 16:52:27]

Moved page-tests into the source directory and suffixed with _browsertest.js

[James Hawkins, 2011-10-22 17:19:26]

Get rid of the "options_page_" prefixes.  If a page is, e.g.,
autofill_options.js, then the test is autofill_options_browsertest.js.

[Sheridan Rawlins, 2011-10-22 18:27:49]

On 2011/10/22 17:19:26, James Hawkins wrote:
> Get rid of the "options_page_" prefixes.  If a page is, e.g.,
> autofill_options.js, then the test is autofill_options_browsertest.js.

done

[James Hawkins, 2011-10-22 19:24:52]

http://codereview.chromium.org/7501004/diff/25001/chrome/chrome_tests.gypi
File chrome/chrome_tests.gypi (right):

http://codereview.chromium.org/7501004/diff/25001/chrome/chrome_tests.gypi#ne...
chrome/chrome_tests.gypi:2515:
'browser/ui/webui/options/certificates_options_browsertest.js',
content_settings_browsertest.js

http://codereview.chromium.org/7501004/diff/25001/chrome/chrome_tests.gypi#ne...
chrome/chrome_tests.gypi:2517:
'browser/ui/webui/options/contentexceptions_options_browsertest.js',
content_settings_exception_area_browsertest.js

http://codereview.chromium.org/7501004/diff/25001/chrome/chrome_tests.gypi#ne...
chrome/chrome_tests.gypi:2518:
'browser/ui/webui/options/cookies_options_browsertest.js',
cookies_view_browsertest.js

http://codereview.chromium.org/7501004/diff/25001/chrome/chrome_tests.gypi#ne...
chrome/chrome_tests.gypi:2519:
'browser/ui/webui/options/fonts_options_browsertest.js',
font_settings_browsertest.js

http://codereview.chromium.org/7501004/diff/25001/chrome/chrome_tests.gypi#ne...
chrome/chrome_tests.gypi:2522:
'browser/ui/webui/options/passwords_options_browsertest.js',
password_manager_browsertest.js

http://codereview.chromium.org/7501004/diff/25001/chrome/chrome_tests.gypi#ne...
chrome/chrome_tests.gypi:2524:
'browser/ui/webui/options/searchengines_options_browsertest.js',
search_engine_manager_browsertest.js

[Sheridan Rawlins, 2011-10-22 20:51:40]

James - what's your take on the test fixtures containing OptionsWebUITest -
should the Options be removed if it's not in the name and the test fixtures have
closer agreement to the filename they're testing?

http://codereview.chromium.org/7501004/diff/25001/chrome/chrome_tests.gypi
File chrome/chrome_tests.gypi (right):

http://codereview.chromium.org/7501004/diff/25001/chrome/chrome_tests.gypi#ne...
chrome/chrome_tests.gypi:2515:
'browser/ui/webui/options/certificates_options_browsertest.js',
Further investigation shows this is only enabled on non-win/mac systems and
tests the certificate manager.  Adjusting accordingly.

On 2011/10/22 19:24:52, James Hawkins wrote:
> content_settings_browsertest.js

http://codereview.chromium.org/7501004/diff/25001/chrome/chrome_tests.gypi#ne...
chrome/chrome_tests.gypi:2517:
'browser/ui/webui/options/contentexceptions_options_browsertest.js',
On 2011/10/22 19:24:52, James Hawkins wrote:
> content_settings_exception_area_browsertest.js

Done.

http://codereview.chromium.org/7501004/diff/25001/chrome/chrome_tests.gypi#ne...
chrome/chrome_tests.gypi:2518:
'browser/ui/webui/options/cookies_options_browsertest.js',
On 2011/10/22 19:24:52, James Hawkins wrote:
> cookies_view_browsertest.js

Done.

http://codereview.chromium.org/7501004/diff/25001/chrome/chrome_tests.gypi#ne...
chrome/chrome_tests.gypi:2519:
'browser/ui/webui/options/fonts_options_browsertest.js',
On 2011/10/22 19:24:52, James Hawkins wrote:
> font_settings_browsertest.js

Done.

http://codereview.chromium.org/7501004/diff/25001/chrome/chrome_tests.gypi#ne...
chrome/chrome_tests.gypi:2522:
'browser/ui/webui/options/passwords_options_browsertest.js',
On 2011/10/22 19:24:52, James Hawkins wrote:
> password_manager_browsertest.js

Done.

http://codereview.chromium.org/7501004/diff/25001/chrome/chrome_tests.gypi#ne...
chrome/chrome_tests.gypi:2524:
'browser/ui/webui/options/searchengines_options_browsertest.js',
On 2011/10/22 19:24:52, James Hawkins wrote:
> search_engine_manager_browsertest.js

Done.

[James Hawkins, 2011-10-24 00:27:34]

On 2011/10/22 20:51:40, Sheridan Rawlins wrote:
> James - what's your take on the test fixtures containing OptionsWebUITest -
> should the Options be removed if it's not in the name and the test fixtures
have
> closer agreement to the filename they're testing?
> 

Yes, sounds good.

[Sheridan Rawlins, 2011-10-24 18:01:28]

Done.

On 2011/10/24 00:27:34, James Hawkins wrote:
> On 2011/10/22 20:51:40, Sheridan Rawlins wrote:
> > James - what's your take on the test fixtures containing OptionsWebUITest -
> > should the Options be removed if it's not in the name and the test fixtures
> have
> > closer agreement to the filename they're testing?
> > 
> 
> Yes, sounds good.

[James Hawkins, 2011-10-24 22:12:50]

lgtm

[commit-bot: I haz the power, 2011-10-24 22:14:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scr@chromium.org/7501004/27001

[commit-bot: I haz the power, 2011-10-24 23:51:41]

Change committed as 107017