Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7341)

Unified Diff: chrome/browser/ui/webui/options/options_browsertest.js

Issue 7501004: Add test to each OptionsPage to open that page (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Made test fixture names better/agree with the filenames. Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/options_browsertest.js
diff --git a/chrome/browser/ui/webui/options/options_browsertest.js b/chrome/browser/ui/webui/options/options_browsertest.js
index e3ec6abe6d90ff4014465de2501f5b9140f3cd7c..a97331c6f4bd8f4690c3d01cd82c8e6cef7ca7bc 100644
--- a/chrome/browser/ui/webui/options/options_browsertest.js
+++ b/chrome/browser/ui/webui/options/options_browsertest.js
@@ -104,18 +104,3 @@ TEST_F('OptionsWebUITest', 'MAYBE_testRefreshStaysOnCurrentPage', function() {
assertEquals(expectedTitle, actualTitle);
assertEquals(pageInstance, topPage);
});
-
-// Test that there are no console errors after opening all registered pages.
-// Crashes on chromium os, flaky on other platforms. See crbug.com/90420.
-// Disabling on Mac OS X since the failure rate is now >50%.
-GEN('#if defined(TOOLKIT_VIEWS) || defined(OS_MACOSX)');
-GEN('#define MAYBE_testOpenAllOptionsPages DISABLED_testOpenAllOptionsPages');
-GEN('#else');
-GEN('#define MAYBE_testOpenAllOptionsPages FLAKY_testOpenAllOptionsPages');
-GEN('#endif // defined(TOOLKIT_VIEWS)');
-TEST_F('OptionsWebUITest', 'MAYBE_testOpenAllOptionsPages', function() {
- expectTrue(!!OptionsPage.registeredPages);
- for (var name in OptionsPage.registeredPages) {
- OptionsPage.showPageByName(name, false);
- }
-});

Powered by Google App Engine
This is Rietveld 408576698