Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Unified Diff: src/arm/lithium-arm.cc

Issue 7497063: Simplify and optimize ToBoolean handling. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/arm/lithium-arm.cc
===================================================================
--- src/arm/lithium-arm.cc (revision 8868)
+++ src/arm/lithium-arm.cc (working copy)
@@ -1039,13 +1039,7 @@
: instr->SecondSuccessor();
return new LGoto(successor->block_id());
}
- LInstruction* branch = new LBranch(UseRegister(v));
- // When we handle all cases, we never deopt, so we don't need to assign the
- // environment then. Note that we map the "empty" case to the "all" case in
- // the code generator.
- ToBooleanStub::Types types = instr->expected_input_types();
- bool all_cases_handled = types.IsAll() || types.IsEmpty();
- return all_cases_handled ? branch : AssignEnvironment(branch);
+ return AssignEnvironment(new LBranch(UseRegister(v)));
}

Powered by Google App Engine
This is Rietveld 408576698