Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Side by Side Diff: src/arm/lithium-arm.cc

Issue 7497063: Simplify and optimize ToBoolean handling. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1021 matching lines...) Expand 10 before | Expand all | Expand 10 after
1032 1032
1033 1033
1034 LInstruction* LChunkBuilder::DoBranch(HBranch* instr) { 1034 LInstruction* LChunkBuilder::DoBranch(HBranch* instr) {
1035 HValue* v = instr->value(); 1035 HValue* v = instr->value();
1036 if (v->EmitAtUses()) { 1036 if (v->EmitAtUses()) {
1037 HBasicBlock* successor = HConstant::cast(v)->ToBoolean() 1037 HBasicBlock* successor = HConstant::cast(v)->ToBoolean()
1038 ? instr->FirstSuccessor() 1038 ? instr->FirstSuccessor()
1039 : instr->SecondSuccessor(); 1039 : instr->SecondSuccessor();
1040 return new LGoto(successor->block_id()); 1040 return new LGoto(successor->block_id());
1041 } 1041 }
1042 LInstruction* branch = new LBranch(UseRegister(v)); 1042 return AssignEnvironment(new LBranch(UseRegister(v)));
1043 // When we handle all cases, we never deopt, so we don't need to assign the
1044 // environment then. Note that we map the "empty" case to the "all" case in
1045 // the code generator.
1046 ToBooleanStub::Types types = instr->expected_input_types();
1047 bool all_cases_handled = types.IsAll() || types.IsEmpty();
1048 return all_cases_handled ? branch : AssignEnvironment(branch);
1049 } 1043 }
1050 1044
1051 1045
1052 1046
1053 LInstruction* LChunkBuilder::DoCompareMap(HCompareMap* instr) { 1047 LInstruction* LChunkBuilder::DoCompareMap(HCompareMap* instr) {
1054 ASSERT(instr->value()->representation().IsTagged()); 1048 ASSERT(instr->value()->representation().IsTagged());
1055 LOperand* value = UseRegisterAtStart(instr->value()); 1049 LOperand* value = UseRegisterAtStart(instr->value());
1056 LOperand* temp = TempRegister(); 1050 LOperand* temp = TempRegister();
1057 return new LCmpMapAndBranch(value, temp); 1051 return new LCmpMapAndBranch(value, temp);
1058 } 1052 }
(...skipping 1135 matching lines...) Expand 10 before | Expand all | Expand 10 after
2194 2188
2195 LInstruction* LChunkBuilder::DoIn(HIn* instr) { 2189 LInstruction* LChunkBuilder::DoIn(HIn* instr) {
2196 LOperand* key = UseRegisterAtStart(instr->key()); 2190 LOperand* key = UseRegisterAtStart(instr->key());
2197 LOperand* object = UseRegisterAtStart(instr->object()); 2191 LOperand* object = UseRegisterAtStart(instr->object());
2198 LIn* result = new LIn(key, object); 2192 LIn* result = new LIn(key, object);
2199 return MarkAsCall(DefineFixed(result, r0), instr); 2193 return MarkAsCall(DefineFixed(result, r0), instr);
2200 } 2194 }
2201 2195
2202 2196
2203 } } // namespace v8::internal 2197 } } // namespace v8::internal
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698