New windows opened in javascript with target = "_blank" should

content/renderer/render_view.cc

Index: content/renderer/render_view.cc
diff --git a/content/renderer/render_view.cc b/content/renderer/render_view.cc
index c74a3cd55f7b037f6ded3ff0cca7b3c944dfcc13..9de7684ad54ac13aefe2e13dacd2e92c95355e62 100644
--- a/content/renderer/render_view.cc
+++ b/content/renderer/render_view.cc
@@ -1326,12 +1326,15 @@ WebView* RenderView::createView(
   if (shared_popup_counter_->data > kMaximumNumberOfUnacknowledgedPopups)
     return NULL;
 
+  WebString fixed_frame_name =

[darin (slow to review), 2011/08/10 21:44:14]

Hmm... perhaps _blank should be stripped on the WebKit side instead?

[shinyak (Google), 2011/08/11 01:52:33]

Hmm... I'm not assure that this is the best position, but Safari can treat with
_blank well.
I try to strip it on the WebKit side, this could break Safari though. If it
breaks Safari, I inform you and we should consider treating _blank on the
Chromium side.

[shinyak (Google), 2011/08/11 06:43:09]

Darin, I've uploaded the patch to WebKit.
https://bugs.webkit.org/show_bug.cgi?id=66030

I'm not assure this patch is accepted. If not so, we should consider handling
this problem on Chromium side, I think.

On 2011/08/11 01:52:33, shinyak wrote:

+    frame_name == "_blank" ? WebString() : frame_name;
+
   ViewHostMsg_CreateWindow_Params params;
   params.opener_id = routing_id_;
   params.user_gesture = creator->isProcessingUserGesture();
   params.window_container_type = WindowFeaturesToContainerType(features);
   params.session_storage_namespace_id = session_storage_namespace_id_;
-  params.frame_name = frame_name;
+  params.frame_name = fixed_frame_name;
   params.opener_frame_id = creator->identifier();
   params.opener_url = creator->document().url();
   params.opener_security_origin =
@@ -1358,7 +1361,7 @@ WebView* RenderView::createView(
                                         shared_popup_counter_,
                                         routing_id,
                                         cloned_session_storage_namespace_id,
-                                        frame_name);
+                                        fixed_frame_name);
   view->opened_by_user_gesture_ = params.user_gesture;
 
   // Record whether the creator frame is trying to suppress the opener field.