New windows opened in javascript with target = "_blank" should

content/renderer/render_view.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_view.h"
 
 #include <algorithm>
 #include <cmath>
 #include <string>
 #include <vector>
@@ skipping 1308 matching lines @@
 
 WebView* RenderView::createView(
     WebFrame* creator,
     const WebURLRequest& request,
     const WebWindowFeatures& features,
     const WebString& frame_name) {
   // Check to make sure we aren't overloading on popups.
   if (shared_popup_counter_->data > kMaximumNumberOfUnacknowledgedPopups)
     return NULL;
 
+  WebString fixed_frame_name =

[darin (slow to review), 2011/08/10 21:44:14]

Hmm... perhaps _blank should be stripped on the WebKit side instead?

[shinyak (Google), 2011/08/11 01:52:33]

Hmm... I'm not assure that this is the best position, but Safari can treat with
_blank well.
I try to strip it on the WebKit side, this could break Safari though. If it
breaks Safari, I inform you and we should consider treating _blank on the
Chromium side.

[shinyak (Google), 2011/08/11 06:43:09]

Darin, I've uploaded the patch to WebKit.
https://bugs.webkit.org/show_bug.cgi?id=66030

I'm not assure this patch is accepted. If not so, we should consider handling
this problem on Chromium side, I think.

On 2011/08/11 01:52:33, shinyak wrote:

+    frame_name == "_blank" ? WebString() : frame_name;
+
   ViewHostMsg_CreateWindow_Params params;
   params.opener_id = routing_id_;
   params.user_gesture = creator->isProcessingUserGesture();
   params.window_container_type = WindowFeaturesToContainerType(features);
   params.session_storage_namespace_id = session_storage_namespace_id_;
-  params.frame_name = frame_name;
+  params.frame_name = fixed_frame_name;
   params.opener_frame_id = creator->identifier();
   params.opener_url = creator->document().url();
   params.opener_security_origin =
       creator->document().securityOrigin().toString().utf8();
   if (!request.isNull())
     params.target_url = request.url();
 
   int32 routing_id = MSG_ROUTING_NONE;
   int64 cloned_session_storage_namespace_id;
   bool opener_suppressed = creator->willSuppressOpenerInNewFrame();
 
   render_thread_->Send(
       new ViewHostMsg_CreateWindow(params,
                                    &routing_id,
                                    &cloned_session_storage_namespace_id));
   if (routing_id == MSG_ROUTING_NONE)
     return NULL;
 
   RenderView* view = RenderView::Create(render_thread_,
                                         0,
                                         routing_id_,
                                         renderer_preferences_,
                                         webkit_preferences_,
                                         shared_popup_counter_,
                                         routing_id,
                                         cloned_session_storage_namespace_id,
-                                        frame_name);
+                                        fixed_frame_name);
   view->opened_by_user_gesture_ = params.user_gesture;
 
   // Record whether the creator frame is trying to suppress the opener field.
   view->opener_suppressed_ = opener_suppressed;
 
   // Record the security origin of the creator.
   GURL creator_url(creator->document().securityOrigin().toString().utf8());
   if (!creator_url.is_valid() || !creator_url.IsStandard())
     creator_url = GURL();
   view->creator_url_ = creator_url;
@@ skipping 3084 matching lines @@
 }
 #endif
 
 void RenderView::OnContextMenuClosed(
     const webkit_glue::CustomContextMenuContext& custom_context) {
   if (custom_context.is_pepper_menu)
     pepper_delegate_.OnContextMenuClosed(custom_context);
   else
     context_menu_node_.reset();
 }