Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 7497049: Quick-fixes to about:tracing following move (Closed)

Created:
9 years, 4 months ago by nduca
Modified:
9 years, 4 months ago
Reviewers:
dominich
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

- Fix stale references to gpu namesapce in about:tracing. - Use flexbox on toplevel div so timeline fills window - Fix overlay_test, which was regressing - Shrink "title" header to h3 and reduce padding - Send gpuInfo and clientInfo to tracing_controller so saved files get those fields Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96246

Patch Set 1 #

Patch Set 2 : Mo fixes #

Patch Set 3 : More minor tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -105 lines) Patch
M chrome/browser/resources/tracing.html View 1 2 3 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/resources/tracing/overlay_test.html View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/tracing/timeline.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/tracing/timeline_track.js View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/tracing/tracing_controller.js View 1 2 3 chunks +21 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/tracing_ui.cc View 1 2 5 chunks +33 lines, -94 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
dominich
9 years, 4 months ago (2011-08-09 23:38:06 UTC) #1
LGTM

Powered by Google App Engine
This is Rietveld 408576698