Quick-fixes to about:tracing following move

chrome/browser/ui/webui/tracing_ui.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/tracing_ui.h"
 
 #include <string>
 
 #include "base/command_line.h"
 #include "base/file_util.h"
@@ skipping 46 matching lines @@
   // SelectFileDialog::Listener implementation
   virtual void FileSelected(const FilePath& path, int index, void* params);
   virtual void FileSelectionCanceled(void* params);
 
   // TraceSubscriber implementation.
   virtual void OnEndTracingComplete();
   virtual void OnTraceDataCollected(const std::string& json_events);
   virtual void OnTraceBufferPercentFullReply(float percent_full);
 
   // Messages.
-  void OnBrowserBridgeInitialized(const ListValue* list);
-  void OnCallAsync(const ListValue* list);
+  void OnTracingControllerInitialized(const ListValue* list);
   void OnBeginTracing(const ListValue* list);
   void OnEndTracingAsync(const ListValue* list);
   void OnBeginRequestBufferPercentFull(const ListValue* list);
   void OnLoadTraceFile(const ListValue* list);
   void OnSaveTraceFile(const ListValue* list);
 
-  // Submessages dispatched from OnCallAsync.
-  Value* OnRequestClientInfo(const ListValue* list);
-  Value* OnRequestLogMessages(const ListValue* list);
-
   // Callbacks.
   void OnGpuInfoUpdate();
 
   // Callbacks.
   void LoadTraceFileComplete(std::string* file_contents);
   void SaveTraceFileComplete();
 
   // Executes the javascript function |function_name| in the renderer, passing
   // it the argument |value|.
   void CallJavascriptFunction(const std::wstring& function_name,
@@ skipping 78 matching lines @@
 WebUIMessageHandler* TracingMessageHandler::Attach(WebUI* web_ui) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   WebUIMessageHandler* result = WebUIMessageHandler::Attach(web_ui);
   return result;
 }
 
 void TracingMessageHandler::RegisterMessages() {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
 
   web_ui_->RegisterMessageCallback(
-      "browserBridgeInitialized",
-      NewCallback(this, &TracingMessageHandler::OnBrowserBridgeInitialized));
-  web_ui_->RegisterMessageCallback(
-      "callAsync",
-      NewCallback(this, &TracingMessageHandler::OnCallAsync));
+      "tracingControllerInitialized",
+      NewCallback(this,
+                  &TracingMessageHandler::OnTracingControllerInitialized));
   web_ui_->RegisterMessageCallback(
       "beginTracing",
       NewCallback(this, &TracingMessageHandler::OnBeginTracing));
   web_ui_->RegisterMessageCallback(
       "endTracingAsync",
       NewCallback(this, &TracingMessageHandler::OnEndTracingAsync));
   web_ui_->RegisterMessageCallback(
       "beginRequestBufferPercentFull",
       NewCallback(this,
                   &TracingMessageHandler::OnBeginRequestBufferPercentFull));
   web_ui_->RegisterMessageCallback(
       "loadTraceFile",
       NewCallback(this, &TracingMessageHandler::OnLoadTraceFile));
   web_ui_->RegisterMessageCallback(
       "saveTraceFile",
       NewCallback(this, &TracingMessageHandler::OnSaveTraceFile));
 }
 
-void TracingMessageHandler::OnCallAsync(const ListValue* args) {
-  DCHECK_GE(args->GetSize(), static_cast<size_t>(2));
-  // unpack args into requestId, submessage and submessageArgs
-  bool ok;
-  Value* requestId;
-  ok = args->Get(0, &requestId);
-  DCHECK(ok);
-
-  std::string submessage;
-  ok = args->GetString(1, &submessage);
-  DCHECK(ok);
-
-  ListValue* submessageArgs = new ListValue();
-  for (size_t i = 2; i < args->GetSize(); ++i) {
-    Value* arg;
-    ok = args->Get(i, &arg);
-    DCHECK(ok);
-
-    Value* argCopy = arg->DeepCopy();
-    submessageArgs->Append(argCopy);
-  }
-
-  // call the submessage handler
-  Value* ret = NULL;
-  if (submessage == "requestClientInfo") {
-    ret = OnRequestClientInfo(submessageArgs);
-  } else if (submessage == "requestLogMessages") {
-    ret = OnRequestLogMessages(submessageArgs);
-  } else {  // unrecognized submessage
-    NOTREACHED();
-    delete submessageArgs;
-    return;
-  }
-  delete submessageArgs;
-
-  // call BrowserBridge.onCallAsyncReply with result
-  if (ret) {
-    web_ui_->CallJavascriptFunction("browserBridge.onCallAsyncReply",
-        *requestId,
-        *ret);
-    delete ret;
-  } else {
-    web_ui_->CallJavascriptFunction("browserBridge.onCallAsyncReply",
-        *requestId);
-  }
-}
-
-void TracingMessageHandler::OnBrowserBridgeInitialized(const ListValue* args) {
+void TracingMessageHandler::OnTracingControllerInitialized(
+    const ListValue* args) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
 
   DCHECK(!gpu_info_update_callback_);
 
   // Watch for changes in GPUInfo
   gpu_info_update_callback_ =
       NewCallback(this, &TracingMessageHandler::OnGpuInfoUpdate);
   gpu_data_manager_->AddGpuInfoUpdateCallback(gpu_info_update_callback_);
 
   // Tell GpuDataManager it should have full GpuInfo. If the
   // Gpu process has not run yet, this will trigger its launch.
   gpu_data_manager_->RequestCompleteGpuInfoIfNeeded();
 
   // Run callback immediately in case the info is ready and no update in the
   // future.
   OnGpuInfoUpdate();
-}
 
-Value* TracingMessageHandler::OnRequestClientInfo(const ListValue* list) {
-  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+  // Send the client info to the tracingController
+  {
+    scoped_ptr<DictionaryValue> dict(new DictionaryValue());
+    chrome::VersionInfo version_info;
 
-  DictionaryValue* dict = new DictionaryValue();
+    if (!version_info.is_valid()) {
+      DLOG(ERROR) << "Unable to create chrome::VersionInfo";
+    } else {
+      // We have everything we need to send the right values.
+      dict->SetString("version", version_info.Version());
+      dict->SetString("cl", version_info.LastChange());
+      dict->SetString("version_mod",
+          chrome::VersionInfo::GetVersionStringModifier());
+      dict->SetString("official",
+          l10n_util::GetStringUTF16(
+              version_info.IsOfficialBuild() ?
+              IDS_ABOUT_VERSION_OFFICIAL :
+              IDS_ABOUT_VERSION_UNOFFICIAL));
 
-  chrome::VersionInfo version_info;
+      dict->SetString("command_line",
+          CommandLine::ForCurrentProcess()->GetCommandLineString());
+    }
 
-  if (!version_info.is_valid()) {
-    DLOG(ERROR) << "Unable to create chrome::VersionInfo";
-  } else {
-    // We have everything we need to send the right values.
-    dict->SetString("version", version_info.Version());
-    dict->SetString("cl", version_info.LastChange());
-    dict->SetString("version_mod",
-        chrome::VersionInfo::GetVersionStringModifier());
-    dict->SetString("official",
-        l10n_util::GetStringUTF16(
-            version_info.IsOfficialBuild() ?
-            IDS_ABOUT_VERSION_OFFICIAL :
-            IDS_ABOUT_VERSION_UNOFFICIAL));
-
-    dict->SetString("command_line",
-        CommandLine::ForCurrentProcess()->GetCommandLineString());
+    dict->SetString("blacklist_version",
+        GpuDataManager::GetInstance()->GetBlacklistVersion());
+    web_ui_->CallJavascriptFunction("tracingController.onClientInfoUpdate",
+                                    *dict);
   }
-
-  dict->SetString("blacklist_version",
-      GpuDataManager::GetInstance()->GetBlacklistVersion());
-
-  return dict;
-}
-
-Value* TracingMessageHandler::OnRequestLogMessages(const ListValue*) {
-  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
-
-  return gpu_data_manager_->log_messages().DeepCopy();
 }
 
 void TracingMessageHandler::OnBeginRequestBufferPercentFull(
     const ListValue* list) {
   TraceController::GetInstance()->GetTraceBufferPercentFullAsync(this);
 }
 
 void TracingMessageHandler::OnGpuInfoUpdate() {
   // Get GPU Info.
   scoped_ptr<base::DictionaryValue> gpu_info_val(
       gpu_data_manager_->GpuInfoAsDictionaryValue());
 
   // Add in blacklisting features
   Value* feature_status = gpu_data_manager_->GetFeatureStatus();
   if (feature_status)
     gpu_info_val->Set("featureStatus", feature_status);
 
   // Send GPU Info to javascript.
-  web_ui_->CallJavascriptFunction("browserBridge.onGpuInfoUpdate",
+  web_ui_->CallJavascriptFunction("tracingController.onGpuInfoUpdate",
       *(gpu_info_val.get()));
 }
 
 // A task used for asynchronously reading a file to a string. Calls the
 // TaskProxy callback when reading is complete.
 class ReadTraceFileTask : public Task {
  public:
   ReadTraceFileTask(TaskProxy* proxy, const FilePath& path)
       : proxy_(proxy),
         path_(path) {}
@@ skipping 186 matching lines @@
 //
 ////////////////////////////////////////////////////////////////////////////////
 
 TracingUI::TracingUI(TabContents* contents) : ChromeWebUI(contents) {
   AddMessageHandler((new TracingMessageHandler())->Attach(this));
 
   // Set up the chrome://tracing/ source.
   Profile::FromBrowserContext(contents->browser_context())->
       GetChromeURLDataManager()->AddDataSource(CreateTracingHTMLSource());
 }