Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 7493077: Add pref entry for virtual keyboard (Closed)

Created:
9 years, 4 months ago by Yusuke Sato
Modified:
9 years, 4 months ago
Reviewers:
mazda, bryeung
CC:
chromium-reviews, davemoore+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Add pref entry for virtual keyboard. This CL depends on http://codereview.chromium.org/7497028/. BUG=None TEST=manual, ran unit_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95578

Patch Set 1 #

Total comments: 6

Patch Set 2 : rebase, review fix #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -3 lines) Patch
M chrome/browser/chromeos/input_method/input_method_manager.h View 1 2 chunks +9 lines, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/input_method_manager.cc View 1 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/input_method/virtual_keyboard_selector.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/input_method/virtual_keyboard_selector.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/input_method/virtual_keyboard_selector_unittest.cc View 1 2 2 chunks +37 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/preferences.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/preferences.cc View 1 2 3 chunks +27 lines, -0 lines 0 comments Download
M chrome/common/pref_names.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/pref_names.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Yusuke Sato
9 years, 4 months ago (2011-08-01 06:01:56 UTC) #1
mazda
LGTM
9 years, 4 months ago (2011-08-03 02:10:20 UTC) #2
bryeung
http://codereview.chromium.org/7493077/diff/1/chrome/browser/chromeos/input_method/virtual_keyboard_selector.cc File chrome/browser/chromeos/input_method/virtual_keyboard_selector.cc (right): http://codereview.chromium.org/7493077/diff/1/chrome/browser/chromeos/input_method/virtual_keyboard_selector.cc#newcode139 chrome/browser/chromeos/input_method/virtual_keyboard_selector.cc:139: void VirtualKeyboardSelector::ClearUserPreference() { should probably be ClearUserPreferences or ClearAllUserPreferences ...
9 years, 4 months ago (2011-08-03 22:15:40 UTC) #3
Yusuke Sato
http://codereview.chromium.org/7493077/diff/1/chrome/browser/chromeos/input_method/virtual_keyboard_selector.cc File chrome/browser/chromeos/input_method/virtual_keyboard_selector.cc (right): http://codereview.chromium.org/7493077/diff/1/chrome/browser/chromeos/input_method/virtual_keyboard_selector.cc#newcode139 chrome/browser/chromeos/input_method/virtual_keyboard_selector.cc:139: void VirtualKeyboardSelector::ClearUserPreference() { On 2011/08/03 22:15:40, bryeung wrote: > ...
9 years, 4 months ago (2011-08-04 07:34:50 UTC) #4
bryeung
9 years, 4 months ago (2011-08-04 17:28:01 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698