Add pref entry for virtual keyboard

chrome/browser/chromeos/input_method/virtual_keyboard_selector_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/input_method/virtual_keyboard_selector.h"
 
 #include "base/logging.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 // For EXPECT_TRUE calls below. The operator has to be in the global namespace.
@@ skipping 382 matching lines @@
   EXPECT_FALSE(selector.SetUserPreference("a", GURL("http://bad_url")));
   EXPECT_EQ(0U, selector.user_preference().size());
   EXPECT_TRUE(selector.SetUserPreference("a", GURL("http://system")));
   EXPECT_EQ(1U, selector.user_preference().size());
   EXPECT_TRUE(selector.SetUserPreference("b", GURL("http://system")));
   EXPECT_EQ(2U, selector.user_preference().size());
   EXPECT_TRUE(selector.SetUserPreference("c", GURL("http://system")));
   EXPECT_EQ(3U, selector.user_preference().size());
 }
 
+TEST(VirtualKeyboardSelectorTest, TestRemoveUserPreference) {
+  static const char* layouts[] = { "a", "b", "c" };
+
+  VirtualKeyboard user_virtual_keyboard_1(
+      GURL("http://user1"), CreateLayoutSet(layouts), false /* is_system */);
+  VirtualKeyboard user_virtual_keyboard_2(
+      GURL("http://user2"), CreateLayoutSet(layouts), false /* is_system */);
+
+  TestableVirtualKeyboardSelector selector;
+  EXPECT_TRUE(selector.AddVirtualKeyboard(
+      user_virtual_keyboard_1.url(),
+      user_virtual_keyboard_1.supported_layouts(),
+      user_virtual_keyboard_1.is_system()));
+  EXPECT_TRUE(selector.AddVirtualKeyboard(
+      user_virtual_keyboard_2.url(),
+      user_virtual_keyboard_2.supported_layouts(),
+      user_virtual_keyboard_2.is_system()));
+
+  EXPECT_TRUE(selector.SetUserPreference("a", GURL("http://user1")));
+  EXPECT_TRUE(selector.SetUserPreference("b", GURL("http://user1")));
+  EXPECT_TRUE(selector.SetUserPreference("c", GURL("http://user1")));
+  EXPECT_EQ(3U, selector.user_preference().size());
+
+  selector.RemoveUserPreference("b");
+  EXPECT_EQ(2U, selector.user_preference().size());
+  ASSERT_TRUE(selector.SelectVirtualKeyboardWithoutPreferences("b"));
+  // user_virtual_keyboard_2 should be selected here since the keyboard is
+  // added most recently and the user preference on "b" is already removed.
+  EXPECT_TRUE(user_virtual_keyboard_2 == *selector.SelectVirtualKeyboard("b"));
+
+  selector.ClearAllUserPreferences();
+  EXPECT_EQ(0U, selector.user_preference().size());
+}
+
 TEST(VirtualKeyboardSelectorTest, TestSetUserPreferenceUserSystemMixed) {
   static const char* ulayouts_1[] = { "a", "b", "c" };
   static const char* ulayouts_2[] = { "a", "c", "d" };
   static const char* layouts_1[] = { "a", "x", "y" };
   static const char* layouts_2[] = { "a", "y", "z" };
 
   VirtualKeyboard user_virtual_keyboard_1(
       GURL("http://user1"), CreateLayoutSet(ulayouts_1), false /* is_system */);
   VirtualKeyboard user_virtual_keyboard_2(
       GURL("http://user2"), CreateLayoutSet(ulayouts_2), false /* is_system */);
@@ skipping 13 matching lines @@
       user_virtual_keyboard_2.is_system()));
   EXPECT_TRUE(selector.AddVirtualKeyboard(
       system_virtual_keyboard_1.url(),
       system_virtual_keyboard_1.supported_layouts(),
       system_virtual_keyboard_1.is_system()));
   EXPECT_TRUE(selector.AddVirtualKeyboard(
       system_virtual_keyboard_2.url(),
       system_virtual_keyboard_2.supported_layouts(),
       system_virtual_keyboard_2.is_system()));
 
-  // Set and then remove user pref (=NOP).
+  // Set and then remove user prefs (=NOP).
   EXPECT_TRUE(selector.SetUserPreference("a", GURL("http://system1")));
-  selector.RemoveUserPreference("a");
+  EXPECT_TRUE(selector.SetUserPreference("z", GURL("http://system2")));
+  selector.ClearAllUserPreferences();
 
   // At this point, user_virtual_keyboard_2 has the highest priority.
   ASSERT_TRUE(selector.SelectVirtualKeyboardWithoutPreferences("a"));
   EXPECT_TRUE(user_virtual_keyboard_2 ==
               *selector.SelectVirtualKeyboard("a"));
   ASSERT_TRUE(selector.SelectVirtualKeyboardWithoutPreferences("c"));
   EXPECT_TRUE(user_virtual_keyboard_2 ==
               *selector.SelectVirtualKeyboard("c"));
   ASSERT_TRUE(selector.SelectVirtualKeyboardWithoutPreferences("d"));
   EXPECT_TRUE(user_virtual_keyboard_2 ==
@@ skipping 53 matching lines @@
               *selector.SelectVirtualKeyboard("a"));
 
   // Switch back to user_virtual_keyboard_1.
   ASSERT_TRUE(selector.SelectVirtualKeyboardWithoutPreferences("c"));
   EXPECT_TRUE(user_virtual_keyboard_2 ==
               *selector.SelectVirtualKeyboard("c"));
 }
 
 }  // namespace input_method
 }  // namespace chromeos