Chromium Code Reviews| Index: presubmit_canned_checks.py |
| diff --git a/presubmit_canned_checks.py b/presubmit_canned_checks.py |
| index a69bacee4ebd630a8377bfa1983b201e9be3e75b..a0b95729477c1344a0f47114829a67a8799d5bc3 100644 |
| --- a/presubmit_canned_checks.py |
| +++ b/presubmit_canned_checks.py |
| @@ -66,8 +66,8 @@ def CheckChangeHasDescription(input_api, output_api): |
| def CheckChangeWasUploaded(input_api, output_api): |
| """Checks that the issue was uploaded before committing.""" |
| - if (input_api.is_committing and |
| - (not input_api.change.issue or not input_api.change.patchset)): |
| + if input_api.is_committing and not input_api.change.issue: |
| + # If patchset is None, it's likely a patchset in issue. |
|
Dirk Pranke
2011/07/25 19:06:54
I don't follow this comment?
M-A Ruel
2011/07/25 19:10:01
That's normal, it didn't make sense either. Fixed.
|
| return [output_api.PresubmitError( |
| 'Issue wasn\'t uploaded. Please upload first.')] |
| return [] |