Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 7491095: Fix findbar z-ordering issue in fullscreen mode. (Closed)

Created:
9 years, 4 months ago by rohitrao (ping after 24h)
Modified:
9 years, 4 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Fix findbar z-ordering issue in fullscreen mode. BUG=74065 TEST=Launch chromium and trigger an infobar. Enter presentation mode, then Cmd-F to trigger find in page. Findbar should be visible even when the overlay is open. TEST=Launch chromium and trigger an infobar. Enter fullscreen, ensure that presentation mode is off (the UI is always visible), then Cmd-F to trigger find in page. Findbar should be visible even when the overlay is open. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95948

Patch Set 1 #

Patch Set 2 : Fix bug in non-presentation mode. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M chrome/browser/ui/cocoa/browser_window_controller.mm View 1 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
rohitrao (ping after 24h)
9 years, 4 months ago (2011-08-08 13:52:03 UTC) #1
Robert Sesek
LGTM if you've verified that infobars still look OK.
9 years, 4 months ago (2011-08-08 15:37:30 UTC) #2
rohitrao (ping after 24h)
This doesn't work with your new infobars. I think the fix is to change the ...
9 years, 4 months ago (2011-08-08 17:58:47 UTC) #3
rohitrao (ping after 24h)
Back to you. Switching the test to presentation mode seems to fix all the problems, ...
9 years, 4 months ago (2011-08-09 00:14:04 UTC) #4
Robert Sesek
LGTM
9 years, 4 months ago (2011-08-09 00:15:53 UTC) #5
commit-bot: I haz the power
9 years, 4 months ago (2011-08-09 05:20:00 UTC) #6
Change committed as 95948

Powered by Google App Engine
This is Rietveld 408576698