Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3671)

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller.mm

Issue 7491095: Fix findbar z-ordering issue in fullscreen mode. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Fix bug in non-presentation mode. Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/browser_window_controller.mm
diff --git a/chrome/browser/ui/cocoa/browser_window_controller.mm b/chrome/browser/ui/cocoa/browser_window_controller.mm
index 91041c593e03322299df1445479c79defd1ab714..212e31e1c39d1036a602644c4386ba6bacebb99a 100644
--- a/chrome/browser/ui/cocoa/browser_window_controller.mm
+++ b/chrome/browser/ui/cocoa/browser_window_controller.mm
@@ -1436,10 +1436,13 @@ enum {
// Create a controller for the findbar.
findBarCocoaController_.reset([findBarCocoaController retain]);
- NSView *contentView = [[self window] contentView];
+ NSView* contentView = [[self window] contentView];
+ NSView* relativeView =
+ [self inPresentationMode] ? [toolbarController_ view] :
+ [infoBarContainerController_ view];
[contentView addSubview:[findBarCocoaController_ view]
positioned:NSWindowAbove
- relativeTo:[infoBarContainerController_ view]];
+ relativeTo:relativeView];
// Place the find bar immediately below the toolbar/attached bookmark bar. In
// presentation mode, it hangs off the top of the screen when the bar is
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698