Issue 7491068: [Sync] Add flag for sessions commit delay in sync.proto

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7491068: [Sync] Add flag for sessions commit delay in sync.proto (Closed)

Created:
9 years, 4 months ago by akalin

Modified:
9 years, 4 months ago

Reviewers:
Nicolas Zea

CC:
chromium-reviews, Raghu Simha, ncarter (slow), tim (not reviewing), idana, Raz Mathias

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

[Sync] Add flag for sessions commit delay in sync.proto BUG=91861 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=96018

Patch Set 2 : Clarify comment #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	chrome/browser/sync/protocol/sync.proto	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Nicolas Zea

LGTM with comment change http://codereview.chromium.org/7491068/diff/1/chrome/browser/sync/protocol/sync.proto File chrome/browser/sync/protocol/sync.proto (right): http://codereview.chromium.org/7491068/diff/1/chrome/browser/sync/protocol/sync.proto#newcode586 chrome/browser/sync/protocol/sync.proto:586: // session notification and sending ...

9 years, 4 months ago (2011-08-06 00:19:50 UTC) #2

akalin

9 years, 4 months ago (2011-08-09 17:58:21 UTC) #3

Clarified the comment, but I disagree with your suggestion.  Committing for now,
we can talk about it when you get back.

http://codereview.chromium.org/7491068/diff/1/chrome/browser/sync/protocol/sy...
File chrome/browser/sync/protocol/sync.proto (right):

http://codereview.chromium.org/7491068/diff/1/chrome/browser/sync/protocol/sy...
chrome/browser/sync/protocol/sync.proto:586: // session notification and sending
a commit
On 2011/08/06 00:19:50, nzea wrote:
> How about calling this "session nudge delay" and same with variable name.

Hmm, 'nudge' is a concept specific to the SyncScheduler, so I think just saying
it's a delay between the sessions action and sending a commit message is better.

Expand Messages | Collapse Messages

Issue 7491068: [Sync] Add flag for sessions commit delay in sync.proto (Closed)

Description

Patch Set 1 #

Patch Set 2 : Clarify comment #

Messages