Merge 91814 - Do not create a new directory database for read operations.

Merge 91814 - Do not create a new directory database for read operations.

BUG=86114, 88454
TEST=manually tested

Review URL: http://codereview.chromium.org/7307013

TBR=kinuko@chromium.org
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=93839

[ericu, 2011-08-01 22:53:27]

Thanks for fixing this--it looks great with one nit.

http://codereview.chromium.org/7489038/diff/1/webkit/fileapi/obfuscated_file_...
File webkit/fileapi/obfuscated_file_system_file_util.cc (right):

http://codereview.chromium.org/7489038/diff/1/webkit/fileapi/obfuscated_file_...
webkit/fileapi/obfuscated_file_system_file_util.cc:853: origin_url, type,
false);
While this code won't actually fail [due to the "true" in the call to
GetDirectoryForOriginType()], passing true would be more correct here, as we
will be creating a new directory database in all cases.

[kinuko, 2011-08-02 08:40:18]

Welcome back :)

On Tue, Aug 2, 2011 at 7:53 AM, <ericu@chromium.org> wrote:

> Thanks for fixing this--it looks great with one nit.
>
>
> http://codereview.chromium.**org/7489038/diff/1/webkit/**
>
fileapi/obfuscated_file_**system_file_util.cc<http://codereview.chromium.org/7489038/diff/1/webkit/fileapi/obfuscated_file_system_file_util.cc>
> File webkit/fileapi/obfuscated_**file_system_file_util.cc (right):
>
> http://codereview.chromium.**org/7489038/diff/1/webkit/**
>
fileapi/obfuscated_file_**system_file_util.cc#newcode853<http://codereview.chromium.org/7489038/diff/1/webkit/fileapi/obfuscated_file_system_file_util.cc#newcode853>
> webkit/fileapi/obfuscated_**file_system_file_util.cc:853: origin_url,
> type, false);
> While this code won't actually fail [due to the "true" in the call to
> GetDirectoryForOriginType()], passing true would be more correct here,
> as we will be creating a new directory database in all cases.
>

True.  Let me know if we should fix it, I can make a tiny patch then!


>
http://codereview.chromium.**org/7489038/<http://codereview.chromium.org/7489...
>

[ericu, 2011-08-04 00:14:45]

On Tue, Aug 2, 2011 at 1:39 AM, Kinuko Yasuda <kinuko@chromium.org> wrote:
> Welcome back :)

Thanks!

> On Tue, Aug 2, 2011 at 7:53 AM, <ericu@chromium.org> wrote:
>>
>> Thanks for fixing this--it looks great with one nit.
>>
>>
>>
>>
http://codereview.chromium.org/7489038/diff/1/webkit/fileapi/obfuscated_file_...
>> File webkit/fileapi/obfuscated_file_system_file_util.cc (right):
>>
>>
>>
http://codereview.chromium.org/7489038/diff/1/webkit/fileapi/obfuscated_file_...
>> webkit/fileapi/obfuscated_file_system_file_util.cc:853: origin_url,
>> type, false);
>> While this code won't actually fail [due to the "true" in the call to
>> GetDirectoryForOriginType()], passing true would be more correct here,
>> as we will be creating a new directory database in all cases.
>
> True.  Let me know if we should fix it, I can make a tiny patch then!

Yes, please do.  I'm happy to review it. ;'>

>> http://codereview.chromium.org/7489038/
>
>