Do not create a new directory database for read operations.

Do not create a new directory database for read operations.

BUG=88454
TEST=manually tested

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91814

[michaeln, 2011-07-05 19:10:12]

lgtm, just one question, i'm not sure what the best answer is

http://codereview.chromium.org/7307013/diff/3001/webkit/fileapi/obfuscated_fi...
File webkit/fileapi/obfuscated_file_system_file_util.cc (right):

http://codereview.chromium.org/7307013/diff/3001/webkit/fileapi/obfuscated_fi...
webkit/fileapi/obfuscated_file_system_file_util.cc:533:
FileSystemDirectoryDatabase* db = GetDirectoryDatabase(
What if the query is about the root directory, should this return true in that
case?

[kinuko, 2011-07-06 07:44:14]

http://codereview.chromium.org/7307013/diff/3001/webkit/fileapi/obfuscated_fi...
File webkit/fileapi/obfuscated_file_system_file_util.cc (right):

http://codereview.chromium.org/7307013/diff/3001/webkit/fileapi/obfuscated_fi...
webkit/fileapi/obfuscated_file_system_file_util.cc:533:
FileSystemDirectoryDatabase* db = GetDirectoryDatabase(
On 2011/07/05 19:10:12, michaeln wrote:
> What if the query is about the root directory, should this return true in that
> case?

Good question, and I don't have a good answer either.

To make it work consistently with ReadDirectory I changed it to return true for
root directory case, put a verbose comment about that.

[michaeln, 2011-07-06 19:39:42]

> To make it work consistently with ReadDirectory I changed it to return true
for
> root directory case, put a verbose comment about that.

sgtm