Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: chrome/test/base/ui_test_utils.cc

Issue 7489019: Fix up various browser tests not to use WaitForNavigation. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Use the single WNO ctor. Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/base/ui_test_utils.cc
diff --git a/chrome/test/base/ui_test_utils.cc b/chrome/test/base/ui_test_utils.cc
index b02d82aecc7e1d59e4158dd6cbcb388edf193572..be65a373fb1505db9b89f87bbd179014a13f6879 100644
--- a/chrome/test/base/ui_test_utils.cc
+++ b/chrome/test/base/ui_test_utils.cc
@@ -57,6 +57,7 @@ namespace ui_test_utils {
namespace {
// Used to block until a navigation completes.
+// TODO(gbillock): this should be merged with TestNavigationObserver
Paweł Hajdan Jr. 2011/08/04 17:56:48 Thanks, and IMHO this is a very high priority. If
Greg Billock 2011/08/11 22:57:45 Sounds good. I'm planning on a sequence of these a
Greg Billock 2011/08/11 22:57:45 Yeah, I plan on a series of changes, and this is n
Paweł Hajdan Jr. 2011/08/11 23:03:02 You can try --gtest_repeat=-1 --gtest_break_on_fai
class NavigationNotificationObserver : public NotificationObserver {
public:
NavigationNotificationObserver(const NotificationSource& source,

Powered by Google App Engine
This is Rietveld 408576698