Fix up various browser tests not to use WaitForNavigation.

chrome/test/base/ui_test_utils.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/test/base/ui_test_utils.h"
 
 #include <vector>
 
 #include "base/callback.h"
 #include "base/command_line.h"
@@ skipping 39 matching lines @@
 
 #if defined(TOOLKIT_VIEWS)
 #include "views/focus/accelerator_handler.h"
 #endif
 
 namespace ui_test_utils {
 
 namespace {
 
 // Used to block until a navigation completes.
+// TODO(gbillock): this should be merged with TestNavigationObserver

[Paweł Hajdan Jr., 2011/08/04 17:56:48]

Thanks, and IMHO this is a very high priority. If you have cycles to do that
right after this change, I'd very much appreciate that.

[Greg Billock, 2011/08/11 22:57:45]

Sounds good. I'm planning on a sequence of these as I have some time, and that's
next on the list. Hopefully it'll include some FLAKY unmarking! :-) Is there a
utility we have for running lots of iterations of a test a la blaze test
--runs_per_test?

[Greg Billock, 2011/08/11 22:57:45]

Yeah, I plan on a series of changes, and this is next on the list. Hopefully
some will be to unmark FLAKY. :-) Do we have an analog to blaze test
runs_per_test?

[Paweł Hajdan Jr., 2011/08/11 23:03:02]

You can try --gtest_repeat=-1 --gtest_break_on_failure, but of course that can't
_prove_ a test is not flaky (but can prove that it is).

Anyway, let's focus on removing risky functions primarily. If that allows us to
remove some FLAKY marks, that's great, but isn't my primary concern.

 class NavigationNotificationObserver : public NotificationObserver {
  public:
   NavigationNotificationObserver(const NotificationSource& source,
                                  int number_of_navigations)
       : navigation_started_(false),
         navigations_completed_(0),
         number_of_navigations_(number_of_navigations),
         running_(false),
         done_(false) {
     registrar_.Add(this, content::NOTIFICATION_NAV_ENTRY_COMMITTED, source);
@@ skipping 973 matching lines @@
   return taker.TakeRenderWidgetSnapshot(rwh, page_size, page_size, bitmap);
 }
 
 bool TakeEntirePageSnapshot(RenderViewHost* rvh, SkBitmap* bitmap) {
   DCHECK(bitmap);
   SnapshotTaker taker;
   return taker.TakeEntirePageSnapshot(rvh, bitmap);
 }
 
 }  // namespace ui_test_utils