Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Unified Diff: chrome/browser/crash_recovery_browsertest.cc

Issue 7489019: Fix up various browser tests not to use WaitForNavigation. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/crash_recovery_browsertest.cc
diff --git a/chrome/browser/crash_recovery_browsertest.cc b/chrome/browser/crash_recovery_browsertest.cc
index f942aed55ece4bc245c66d65eaadbf4871e99fed..cb44a194c9830404f260e563c31e9927641f13b8 100644
--- a/chrome/browser/crash_recovery_browsertest.cc
+++ b/chrome/browser/crash_recovery_browsertest.cc
@@ -15,12 +15,12 @@
namespace {
void SimulateRendererCrash(Browser* browser) {
+ ui_test_utils::WindowedNotificationObserver observer(
+ content::NOTIFICATION_TAB_CONTENTS_DISCONNECTED,
+ NotificationService::AllSources());
browser->OpenURL(GURL(chrome::kChromeUICrashURL), GURL(), CURRENT_TAB,
PageTransition::TYPED);
- LOG(ERROR) << "SimulateRendererCrash, before WaitForNotification";
- ui_test_utils::WaitForNotification(
- content::NOTIFICATION_TAB_CONTENTS_DISCONNECTED);
- LOG(ERROR) << "SimulateRendererCrash, after WaitForNotification";
+ observer.Wait();
}
} // namespace
@@ -42,10 +42,9 @@ IN_PROC_BROWSER_TEST_F(CrashRecoveryBrowserTest, Reload) {
ASSERT_TRUE(ui_test_utils::GetCurrentTabTitle(browser(),
&title_before_crash));
SimulateRendererCrash(browser());
+ ui_test_utils::WindowedNotificationObserver observer(*browser());
browser()->Reload(CURRENT_TAB);
- LOG(ERROR) << "Before WaitForNavigationInCurrentTab";
- ASSERT_TRUE(ui_test_utils::WaitForNavigationInCurrentTab(browser()));
- LOG(ERROR) << "After WaitForNavigationInCurrentTab";
+ observer.Wait();
ASSERT_TRUE(ui_test_utils::GetCurrentTabTitle(browser(),
&title_after_crash));
EXPECT_NE(title_before_crash, title_after_crash);
@@ -69,10 +68,9 @@ IN_PROC_BROWSER_TEST_F(CrashRecoveryBrowserTest, LoadInNewTab) {
ASSERT_TRUE(ui_test_utils::GetCurrentTabTitle(browser(),
&title_before_crash));
SimulateRendererCrash(browser());
+ ui_test_utils::WindowedNotificationObserver observer(*browser());
browser()->Reload(CURRENT_TAB);
- LOG(ERROR) << "Before WaitForNavigationInCurrentTab";
- ASSERT_TRUE(ui_test_utils::WaitForNavigationInCurrentTab(browser()));
- LOG(ERROR) << "After WaitForNavigationInCurrentTab";
+ observer.Wait();
ASSERT_TRUE(ui_test_utils::GetCurrentTabTitle(browser(),
&title_after_crash));
EXPECT_EQ(title_before_crash, title_after_crash);

Powered by Google App Engine
This is Rietveld 408576698