Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Unified Diff: chrome/browser/browser_focus_uitest.cc

Issue 7489019: Fix up various browser tests not to use WaitForNavigation. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/browser_focus_uitest.cc
diff --git a/chrome/browser/browser_focus_uitest.cc b/chrome/browser/browser_focus_uitest.cc
index 5e6fc06b4c63bdf128f6e5a8ab3e4c6920dbc809..f3fb650b3aec63812956e370211561b83b733fa1 100644
--- a/chrome/browser/browser_focus_uitest.cc
+++ b/chrome/browser/browser_focus_uitest.cc
@@ -846,11 +846,20 @@ IN_PROC_BROWSER_TEST_F(BrowserFocusTest, FocusOnReload) {
ASSERT_TRUE(test_server()->Start());
// Open the new tab, reload.
- browser()->NewTab();
+ {
+ ui_test_utils::WindowedNotificationObserver observer(
+ content::NOTIFICATION_LOAD_STOP,
+ NotificationService::AllSources());
+ browser()->NewTab();
+ observer.Wait();
+ }
ui_test_utils::RunAllPendingInMessageLoop();
- browser()->Reload(CURRENT_TAB);
- ASSERT_TRUE(ui_test_utils::WaitForNavigationInCurrentTab(browser()));
+ {
+ ui_test_utils::WindowedNotificationObserver observer(*browser());
+ browser()->Reload(CURRENT_TAB);
+ observer.Wait();
+ }
// Focus should stay on the location bar.
ASSERT_TRUE(IsViewFocused(VIEW_ID_LOCATION_BAR));
@@ -858,8 +867,11 @@ IN_PROC_BROWSER_TEST_F(BrowserFocusTest, FocusOnReload) {
ui_test_utils::NavigateToURL(browser(), test_server()->GetURL(kSimplePage));
browser()->FocusLocationBar();
ASSERT_TRUE(IsViewFocused(VIEW_ID_LOCATION_BAR));
- browser()->Reload(CURRENT_TAB);
- ASSERT_TRUE(ui_test_utils::WaitForNavigationInCurrentTab(browser()));
+ {
+ ui_test_utils::WindowedNotificationObserver observer(*browser());
+ browser()->Reload(CURRENT_TAB);
+ observer.Wait();
+ }
// Focus should now be on the tab contents.
browser()->ShowDownloadsTab();
@@ -874,8 +886,11 @@ IN_PROC_BROWSER_TEST_F(BrowserFocusTest, DISABLED_FocusOnReloadCrashedTab) {
// Open a regular page, crash, reload.
ui_test_utils::NavigateToURL(browser(), test_server()->GetURL(kSimplePage));
ui_test_utils::CrashTab(browser()->GetSelectedTabContents());
- browser()->Reload(CURRENT_TAB);
- ASSERT_TRUE(ui_test_utils::WaitForNavigationInCurrentTab(browser()));
+ {
+ ui_test_utils::WindowedNotificationObserver observer(*browser());
+ browser()->Reload(CURRENT_TAB);
+ observer.Wait();
+ }
// Focus should now be on the tab contents.
browser()->ShowDownloadsTab();
« no previous file with comments | « no previous file | chrome/browser/crash_recovery_browsertest.cc » ('j') | chrome/browser/ssl/ssl_browser_tests.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698