Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 7488069: Expose mapExternalTexture extension to WebGraphicsContext3D (Closed)

Created:
9 years, 4 months ago by jamesr
Modified:
9 years, 2 months ago
Reviewers:
apatrick_chromium
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium
Visibility:
Public.

Description

Expose mapExternalTexture extension to WebGraphicsContext3D BUG=80703 TEST=none

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -0 lines) Patch
M content/renderer/gpu/webgraphicscontext3d_command_buffer_impl.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/renderer/gpu/webgraphicscontext3d_command_buffer_impl.cc View 1 chunk +13 lines, -0 lines 1 comment Download
M gpu/command_buffer/service/feature_info.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.h View 2 chunks +5 lines, -0 lines 0 comments Download
M webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M webkit/gpu/webgraphicscontext3d_in_process_impl.h View 1 chunk +3 lines, -0 lines 0 comments Download
M webkit/gpu/webgraphicscontext3d_in_process_impl.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jamesr
9 years, 4 months ago (2011-07-29 23:56:29 UTC) #1
apatrick_chromium
9 years, 4 months ago (2011-07-29 23:59:04 UTC) #2
LGTM

http://codereview.chromium.org/7488069/diff/1/content/renderer/gpu/webgraphic...
File content/renderer/gpu/webgraphicscontext3d_command_buffer_impl.cc (right):

http://codereview.chromium.org/7488069/diff/1/content/renderer/gpu/webgraphic...
content/renderer/gpu/webgraphicscontext3d_command_buffer_impl.cc:347:
static_cast<WebGraphicsContext3DCommandBufferImpl*>(source_context);
indentation

Powered by Google App Engine
This is Rietveld 408576698