Implemented kiosk mode for Mac.

Kiosk mode for Mac

Contributed by fhd@ubercode.de

BUG=23145
TEST=Start with --kiosk and observe that Chromium is started in full screen and that the address bar etc. won't appear.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=144448

[Mohamed Mansour, 2011-07-26 12:21:59]

This LGTM, but I rather have a Mac developer give the final saying such as
rsesek/sail. Good job!

[Mohamed Mansour, 2011-07-26 12:55:49]

Just one minor nit though, can you please remove the last paragraph from the
commit message since that is not technically part of the review, we will just
submit this after the other cl has been submitted.

[fhd, 2011-07-26 14:07:59]

On 2011/07/26 12:55:49, Mohamed Mansour wrote:
> Just one minor nit though, can you please remove the last paragraph from the
> commit message since that is not technically part of the review, we will just
> submit this after the other cl has been submitted.

Done, but I'll add the remark here so that it isn't lost:

Please note that I haven't added myself to the AUTHORS file because I already
did that with the following patch, which will hopefully be merged soon:

http://codereview.chromium.org/7398026/

[Robert Sesek, 2011-07-26 14:13:42]

+rohit

[fhd, 2011-07-28 17:41:41]

Okay, I should be in the authors file now, the following has been committed:

http://codereview.chromium.org/7398026/

[fhd, 2011-08-01 07:33:23]

Is there anything missing for this?

[Hironori Bono, 2011-08-17 06:50:23]

+thakis

[Nico, 2011-08-17 14:25:53]

LGTM

Thanks the patch!

Note that we don't really support kiosk mode, and we only tolerate it because it
was implementable in less than 50 lines, so if it turns out that more code is
needed for this, chances are this CL wil be reverted instead of us accepting
more code.

[fhd, 2011-08-17 15:06:58]

On 2011/08/17 14:25:53, Nico wrote: 
> Note that we don't really support kiosk mode, and we only tolerate it because
it
> was implementable in less than 50 lines, so if it turns out that more code is
> needed for this, chances are this CL wil be reverted instead of us accepting
> more code.

I don't think my code in particular added many lines (should be about 5). Most
of the business was to change preprocessor instructions which previously
excluded Mac.

[Nico, 2011-08-17 15:08:53]

On Wed, Aug 17, 2011 at 8:06 AM,  <fhd@ubercode.de> wrote:
> I don't think my code in particular added many lines (should be about 5).
> Most of the business was to change preprocessor instructions which previously
> excluded Mac.

Yes, this CL is fine :-) I meant the patch that added kiosk support on
win/linux.

[fhd, 2011-09-22 07:53:38]

If everything is fine here, can somebody commit this?

On 2011/08/17 15:08:53, Nico wrote:
> On Wed, Aug 17, 2011 at 8:06 AM,  <mailto:fhd@ubercode.de> wrote:
> > I don't think my code in particular added many lines (should be about 5).
> > Most of the business was to change preprocessor instructions which
previously
> > excluded Mac.
> 
> Yes, this CL is fine :-) I meant the patch that added kiosk support on
> win/linux.

[Hironori Bono, 2011-09-22 08:12:01]

Greetings,

I have sent this change to trybots. If they cycle green, I will land this
change.

Regards,

Hironori Bono

[Hironori Bono, 2011-09-22 08:15:34]

Greetings,

It seems this change causes conflicts with the latest source code of Chromium
and trybots cannot apply this patch. Is it possible to sync your Chromium
repository to the latest one and re-upload the change?

Regards,

Hironori Bono

[fhd, 2011-09-22 08:49:51]

I feared that this would happen, the patch being rather old. I'll sync.

On 2011/09/22 08:15:34, hbono wrote:
> Greetings,
> 
> It seems this change causes conflicts with the latest source code of Chromium
> and trybots cannot apply this patch. Is it possible to sync your Chromium
> repository to the latest one and re-upload the change?
> 
> Regards,
> 
> Hironori Bono

[fhd, 2011-09-22 09:06:43]

Done.

On 2011/09/22 08:15:34, hbono wrote:
> Greetings,
> 
> It seems this change causes conflicts with the latest source code of Chromium
> and trybots cannot apply this patch. Is it possible to sync your Chromium
> repository to the latest one and re-upload the change?
> 
> Regards,
> 
> Hironori Bono

[rohitrao (ping after 24h), 2011-09-22 12:14:58]

Have you tried this out on a Lion machine?  Does it work with both Lion
fullscreen modes, or can users use the "Toggle Presentation Mode" button to
break out of kiosk mode?

[fhd, 2011-09-22 13:40:30]

On 2011/09/22 12:14:58, rohitrao wrote:
> Have you tried this out on a Lion machine?  Does it work with both Lion
> fullscreen modes, or can users use the "Toggle Presentation Mode" button to
> break out of kiosk mode?

No, I have implemented this before Lion was released, and I'm still on Snow
Leopard. But I'll check it out.

[Hironori Bono, 2011-10-05 06:09:02]

Greetings,

> No, I have implemented this before Lion was released, and I'm still on Snow
> Leopard. But I'll check it out.

Have you checked if this change works on Lion? I'm wondering if I can commit
this change.

Regards,

Hironori Bono

[fhd, 2012-03-26 09:11:58]

On 2011/10/05 06:09:02, Hironori Bono wrote:
> Have you checked if this change works on Lion? I'm wondering if I can commit
> this change.

No, sorry. I wasn't able to get my hands on a Lion machine yet, we cannot
upgrade our Macs at work for some reason.

[Hironori Bono, 2012-03-26 09:31:55]

Greetings,

Thanks for your response.
It is not a problem if you cannot test this change on Lion. (We will test it on
Lion.) Is it possible to check the 'commit' check when you are ready to commit
this change?

Regards,

Hironori Bono

[commit-bot: I haz the power, 2012-03-26 09:41:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fhd@ubercode.de/7484029/13001

[commit-bot: I haz the power, 2012-03-26 09:41:48]

Can't apply patch for file chrome/browser/ui/browser.cc.
While running patch -p1 --forward --force;
patching file chrome/browser/ui/browser.cc
Hunk #1 FAILED at 1663.
Hunk #2 succeeded at 5199 (offset 484 lines).
1 out of 2 hunks FAILED -- saving rejects to file
chrome/browser/ui/browser.cc.rej

[fhd, 2012-03-26 09:42:49]

On 2012/03/26 09:31:55, Hironori Bono wrote:
> Thanks for your response.
> It is not a problem if you cannot test this change on Lion. (We will test it
on
> Lion.)

Great! Sorry I didn't get back on this earlier, still hoped we would sort out
our internal upgrade issues...

[commit-bot: I haz the power, 2012-03-26 15:33:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fhd@ubercode.de/7484029/25002

[commit-bot: I haz the power, 2012-03-26 15:33:52]

Presubmit check for 7484029-25002 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/browser/ui

Presubmit checks took 1.4s to calculate.

[fhd, 2012-03-26 15:35:17]

I've merged the changes from trunk and had to change a few things.

[commit-bot: I haz the power, 2012-06-05 10:58:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fhd@ubercode.de/7484029/25002

[commit-bot: I haz the power, 2012-06-05 10:58:36]

Failed to apply patch for chrome/browser/ui/browser_init.cc:
While running patch -p1 --forward --force;
patching file chrome/browser/ui/browser_init.cc
Hunk #1 FAILED at 1267.
1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/ui/browser_init.cc.rej

[commit-bot: I haz the power, 2012-06-05 10:59:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fhd@ubercode.de/7484029/25002

[commit-bot: I haz the power, 2012-06-05 10:59:11]

Failed to apply patch for chrome/browser/ui/browser_init.cc:
While running patch -p1 --forward --force;
patching file chrome/browser/ui/browser_init.cc
Hunk #1 FAILED at 1267.
1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/ui/browser_init.cc.rej

[commit-bot: I haz the power, 2012-06-05 11:01:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fhd@ubercode.de/7484029/25002

[commit-bot: I haz the power, 2012-06-05 11:01:26]

Failed to apply patch for chrome/browser/ui/browser_init.cc:
While running patch -p1 --forward --force;
patching file chrome/browser/ui/browser_init.cc
Hunk #1 FAILED at 1267.
1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/ui/browser_init.cc.rej

[fhd, 2012-06-05 11:01:39]

I think I'll need LGTMs before the tests can be run.

[commit-bot: I haz the power, 2012-06-05 11:01:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fhd@ubercode.de/7484029/25002

[commit-bot: I haz the power, 2012-06-05 11:01:58]

Failed to apply patch for chrome/browser/ui/browser_init.cc:
While running patch -p1 --forward --force;
patching file chrome/browser/ui/browser_init.cc
Hunk #1 FAILED at 1267.
1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/ui/browser_init.cc.rej

[Bernhard Bauer, 2012-06-05 11:04:55]

On 2012/06/05 11:01:39, fhd wrote:
> I think I'll need LGTMs before the tests can be run.

No, the patch doesn't apply anymore. You're going to need to rebase and fix the
resulting conflicts.

[fhd, 2012-06-05 11:07:22]

On 2012/06/05 11:04:55, Bernhard Bauer wrote:
> On 2012/06/05 11:01:39, fhd wrote:
> > I think I'll need LGTMs before the tests can be run.
> 
> No, the patch doesn't apply anymore. You're going to need to rebase and fix
the
> resulting conflicts.

Sorry, still having problems gettings used to Rietveld.

My workflow is currently like this:

1. Wait for feedback/LGTM
2. Notice that I have to do something (e.g. click "Commit")
3. Notice that the patch doesn't apply anymore
4. Rebase
5. Go back to 1

I'll do it properly this time :)

[commit-bot: I haz the power, 2012-06-08 08:45:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fhd@ubercode.de/7484029/39002

[commit-bot: I haz the power, 2012-06-08 08:45:31]

Presubmit check for 7484029-39002 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/browser/ui

Presubmit checks took 1.8s to calculate.

[Nico, 2012-06-14 22:54:54]

sky: OWNERS for chrome/browser/ui please

[sky, 2012-06-14 23:09:34]

LGTM

[commit-bot: I haz the power, 2012-06-23 13:37:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fhd@ubercode.de/7484029/39002

[commit-bot: I haz the power, 2012-06-23 13:37:55]

Failed to apply patch for
chrome/browser/ui/cocoa/browser_window_controller_private.mm:
While running patch -p1 --forward --force;
patching file chrome/browser/ui/cocoa/browser_window_controller_private.mm
Hunk #1 FAILED at 29.
Hunk #2 succeeded at 682 (offset 5 lines).
1 out of 2 hunks FAILED -- saving rejects to file
chrome/browser/ui/cocoa/browser_window_controller_private.mm.rej

[commit-bot: I haz the power, 2012-06-27 12:15:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fhd@ubercode.de/7484029/45002

[commit-bot: I haz the power, 2012-06-27 13:19:18]

Change committed as 144448