Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 7484007: Move sync performance tests into new target (Closed)

Created:
9 years, 5 months ago by braffert
Modified:
9 years, 5 months ago
CC:
chromium-reviews, ncarter (slow), idana, Raghu Simha, Erik does not do reviews, Aaron Boodman, Paweł Hajdan Jr., tim (not reviewing)
Visibility:
Public.

Description

Move sync performance tests into new target This patch moves all sync performance tests out of sync_integration_tests and into a new target: sync_performance_tests. Since the performance tests make use of the existing integration test framework, I have duplicated the dependencies and conditions in chrome_tests.gypi. All performance tests as well as the timing helper class have been moved into live_sync/perf. The class naming convention has been changed as well, but the tests themselves are unmodified. The --test-terminate-timeout flag must be used to raise the timout to around 1 minute for all tests to pass. The passwords tests are the culprit here, as they run significantly slower than the rest of the datatypes. Eventually I would like to have a SyncPerfTest base class which overrides the default timeout, but this is not possible with the current inheritance hierarchy. BUG=89824 TEST=sync_performance_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=93688

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : re-upload #

Patch Set 4 : re-upload again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+228 lines, -1049 lines) Patch
M chrome/chrome_tests.gypi View 1 2 3 3 chunks +109 lines, -7 lines 0 comments Download
D chrome/test/live_sync/live_sync_timing_helper.h View 1 chunk +0 lines, -41 lines 0 comments Download
D chrome/test/live_sync/live_sync_timing_helper.cc View 1 chunk +0 lines, -34 lines 0 comments Download
A + chrome/test/live_sync/performance/autofill_sync_perf_test.cc View 13 chunks +23 lines, -23 lines 0 comments Download
A + chrome/test/live_sync/performance/bookmarks_sync_perf_test.cc View 12 chunks +22 lines, -21 lines 0 comments Download
A + chrome/test/live_sync/performance/extensions_sync_perf_test.cc View 10 chunks +18 lines, -18 lines 0 comments Download
A + chrome/test/live_sync/performance/passwords_sync_perf_test.cc View 12 chunks +20 lines, -20 lines 0 comments Download
A + chrome/test/live_sync/performance/sync_timing_helper.h View 3 chunks +7 lines, -7 lines 0 comments Download
A + chrome/test/live_sync/performance/sync_timing_helper.cc View 1 chunk +9 lines, -6 lines 0 comments Download
A + chrome/test/live_sync/performance/typed_urls_sync_perf_test.cc View 12 chunks +20 lines, -20 lines 0 comments Download
D chrome/test/live_sync/performance_live_autofill_sync_test.cc View 1 chunk +0 lines, -199 lines 0 comments Download
D chrome/test/live_sync/performance_live_bookmarks_sync_test.cc View 1 chunk +0 lines, -168 lines 0 comments Download
D chrome/test/live_sync/performance_live_extensions_sync_test.cc View 1 chunk +0 lines, -154 lines 0 comments Download
D chrome/test/live_sync/performance_live_passwords_sync_test.cc View 1 chunk +0 lines, -165 lines 0 comments Download
D chrome/test/live_sync/performance_live_typed_urls_sync_test.cc View 1 chunk +0 lines, -166 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
braffert
Previous attempt was at http://codereview.chromium.org/7376001/ Commit failed because the new performance tests target uses the ...
9 years, 5 months ago (2011-07-21 20:36:19 UTC) #1
anna
LGTM.
9 years, 5 months ago (2011-07-22 18:52:58 UTC) #2
commit-bot: I haz the power
9 years, 5 months ago (2011-07-22 19:19:24 UTC) #3
Can't process patch for file
chrome/test/live_sync/performance/typed_urls_sync_perf_test.cc.
A +

Powered by Google App Engine
This is Rietveld 408576698