Issue 7484: [chromium-reviews] Fix a potential crasher in SpellChecker Add to dictionary feature....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7484: [chromium-reviews] Fix a potential crasher in SpellChecker Add to dictionary feature.... (Closed)

Created:
12 years, 2 months ago by sidchat (Google)

Modified:
9 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix a potential crasher in SpellChecker Add to dictionary feature. Issue=3039 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=3546

Patch Set 1 #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	chrome/browser/spellchecker.cc	View		1 chunk	+2 lines, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Patrick Johnson

12 years, 2 months ago (2008-10-17 18:13:15 UTC) #2

http://codereview.chromium.org/7484/diff/1/2
File chrome/browser/spellchecker.cc (right):

http://codereview.chromium.org/7484/diff/1/2#newcode513
Line 513: if (f != NULL)
This looks like a good fix, but won't the silent failure be a little confusing
for the user?

Expand Messages | Collapse Messages