[chromium-reviews] Fix a potential crasher in SpellChecker Add to dictionary feature....

chrome/browser/spellchecker.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <io.h>
 
 #include "chrome/browser/spellchecker.h"
 #include "base/basictypes.h"
 #include "base/file_util.h"
 #include "base/histogram.h"
@@ skipping 492 matching lines @@
   }
 
  private:
   void Run() {
     // Add the word with a new line. Note that, although this would mean an
     // extra line after the list of words, this is potentially harmless and
     // faster, compared to verifying everytime whether to append a new line
     // or not.
     word_ += "\n";
     FILE* f = file_util::OpenFile(file_name_, "a+");
-    fputs(word_.c_str(), f);
+    if (f != NULL)

[Patrick Johnson, 2008/10/17 18:13:15]

This looks like a good fix, but won't the silent failure be a little confusing
for the user?

+      fputs(word_.c_str(), f);
     file_util::CloseFile(f);
   }
 
   std::string file_name_;
   std::string word_;
 };
 
 void SpellChecker::AddWord(const std::wstring& word) {
   // Check if the |hunspell_| has been initialized at all.
   Initialize();
 
   // Add the word to hunspell.
   std::string word_to_add = WideToUTF8(word);
   if (!word_to_add.empty())
     hunspell_->put_word(word_to_add.c_str());
 
   // Now add the word to the custom dictionary file in the file loop.
   if (file_loop_) {
     file_loop_->PostTask(FROM_HERE, new AddWordToCustomDictionaryTask(
         custom_dictionary_file_name_, word));
   } else {  // just run it in this thread.
     Task* write_word_task = new AddWordToCustomDictionaryTask(
         custom_dictionary_file_name_, word);
     write_word_task->Run();
   }
 }