Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Issue 7471006: Revert 93223 - Reland http://codereview.chromium.org/7452002/ (Closed)

Created:
9 years, 5 months ago by dmichael (off chromium)
Modified:
9 years, 5 months ago
CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, Paweł Hajdan Jr., dmaclach+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, darin-cc_chromium.org, ajwong+watch_chromium.org, piman+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Revert 93223 - Reland http://codereview.chromium.org/7452002/ Update chromoting input events. (Clang caught this. Thanks, Clang!) Note I'm leaving in temporary backwards-compatibility. brettw, just need a rubber-stamp. This is the same as the last CL. awong/garykac/sergeyu, looking for someone on chromoting team to glance at my changes and make sure I didn't do anything you don't like. This is a high priority for 14, so please look if you can. BUG=None TEST=ppapi tests Review URL: http://codereview.chromium.org/7466002 TBR=dmichael@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=93229

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+325 lines, -222 lines) Patch
M ppapi/api/ppp_instance.idl View 3 chunks +37 lines, -8 lines 0 comments Download
M ppapi/c/pp_input_event.h View 1 chunk +38 lines, -0 lines 0 comments Download
M ppapi/c/ppp_instance.h View 4 chunks +35 lines, -10 lines 0 comments Download
M ppapi/cpp/instance.h View 1 chunk +4 lines, -1 line 0 comments Download
M ppapi/cpp/instance.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ppapi/cpp/module.cc View 2 chunks +12 lines, -0 lines 0 comments Download
M ppapi/examples/2d/graphics_2d_example.c View 2 chunks +7 lines, -0 lines 0 comments Download
M ppapi/examples/2d/paint_manager_example.cc View 2 chunks +10 lines, -12 lines 0 comments Download
M ppapi/examples/file_chooser/file_chooser.cc View 3 chunks +6 lines, -9 lines 0 comments Download
M ppapi/proxy/dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppapi_messages.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ppapi/proxy/ppapi_param_traits.h View 2 chunks +9 lines, -0 lines 0 comments Download
M ppapi/proxy/ppapi_param_traits.cc View 1 chunk +24 lines, -0 lines 0 comments Download
M ppapi/proxy/ppp_instance_proxy.h View 3 chunks +6 lines, -2 lines 0 comments Download
M ppapi/proxy/ppp_instance_proxy.cc View 5 chunks +29 lines, -5 lines 0 comments Download
M ppapi/proxy/ppp_instance_proxy_test.cc View 4 chunks +29 lines, -6 lines 0 comments Download
M ppapi/shared_impl/ppp_instance_combined.h View 1 chunk +1 line, -41 lines 0 comments Download
M ppapi/shared_impl/ppp_instance_combined.cc View 1 chunk +1 line, -13 lines 0 comments Download
M remoting/client/plugin/chromoting_instance.h View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/client/plugin/chromoting_instance.cc View 3 chunks +17 lines, -26 lines 0 comments Download
M remoting/client/plugin/pepper_input_handler.h View 3 chunks +5 lines, -10 lines 0 comments Download
M remoting/client/plugin/pepper_input_handler.cc View 2 chunks +13 lines, -15 lines 0 comments Download
M webkit/plugins/ppapi/event_conversion.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M webkit/plugins/ppapi/plugin_module.cc View 2 chunks +1 line, -8 lines 0 comments Download
M webkit/plugins/ppapi/ppapi_plugin_instance.h View 1 chunk +0 lines, -6 lines 0 comments Download
M webkit/plugins/ppapi/ppapi_plugin_instance.cc View 11 chunks +22 lines, -38 lines 0 comments Download
M webkit/plugins/ppapi/ppapi_unittest.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M webkit/plugins/ppapi/resource_tracker_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
dmichael (off chromium)
9 years, 5 months ago (2011-07-20 18:53:12 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698