Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 7466002: Reland http://codereview.chromium.org/7452002/, update chromoting (Closed)

Created:
9 years, 5 months ago by dmichael (off chromium)
Modified:
9 years, 5 months ago
CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, Paweł Hajdan Jr., dmaclach+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, darin-cc_chromium.org, ajwong+watch_chromium.org, piman+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Reland http://codereview.chromium.org/7452002/ Update chromoting input events. (Clang caught this. Thanks, Clang!) Note I'm leaving in temporary backwards-compatibility. brettw, just need a rubber-stamp. This is the same as the last CL. awong/garykac/sergeyu, looking for someone on chromoting team to glance at my changes and make sure I didn't do anything you don't like. This is a high priority for 14, so please look if you can. BUG=None TEST=ppapi tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=93223

Patch Set 1 #

Patch Set 2 : fix windows compile error #

Patch Set 3 : a few compile fixes (sorry) #

Total comments: 2

Patch Set 4 : removed empty lines #

Patch Set 5 : copyright #

Unified diffs Side-by-side diffs Delta from patch set Stats (+223 lines, -326 lines) Patch
M ppapi/api/ppp_instance.idl View 3 chunks +8 lines, -37 lines 0 comments Download
M ppapi/c/pp_input_event.h View 1 chunk +0 lines, -38 lines 0 comments Download
M ppapi/c/ppp_instance.h View 4 chunks +10 lines, -35 lines 0 comments Download
M ppapi/cpp/instance.h View 1 chunk +1 line, -4 lines 0 comments Download
M ppapi/cpp/instance.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ppapi/cpp/module.cc View 2 chunks +0 lines, -12 lines 0 comments Download
M ppapi/examples/2d/graphics_2d_example.c View 2 chunks +0 lines, -7 lines 0 comments Download
M ppapi/examples/2d/paint_manager_example.cc View 2 chunks +12 lines, -10 lines 0 comments Download
M ppapi/examples/file_chooser/file_chooser.cc View 3 chunks +9 lines, -6 lines 0 comments Download
M ppapi/proxy/dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppapi_messages.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ppapi/proxy/ppapi_param_traits.h View 2 chunks +0 lines, -9 lines 0 comments Download
M ppapi/proxy/ppapi_param_traits.cc View 1 chunk +0 lines, -24 lines 0 comments Download
M ppapi/proxy/ppp_instance_proxy.h View 3 chunks +2 lines, -6 lines 0 comments Download
M ppapi/proxy/ppp_instance_proxy.cc View 5 chunks +5 lines, -29 lines 0 comments Download
M ppapi/proxy/ppp_instance_proxy_test.cc View 4 chunks +6 lines, -29 lines 0 comments Download
M ppapi/shared_impl/ppp_instance_combined.h View 1 chunk +41 lines, -1 line 0 comments Download
M ppapi/shared_impl/ppp_instance_combined.cc View 1 chunk +13 lines, -1 line 0 comments Download
M remoting/client/plugin/chromoting_instance.h View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/client/plugin/chromoting_instance.cc View 1 2 3 chunks +26 lines, -17 lines 0 comments Download
M remoting/client/plugin/pepper_input_handler.h View 1 2 3 4 3 chunks +10 lines, -5 lines 0 comments Download
M remoting/client/plugin/pepper_input_handler.cc View 1 2 2 chunks +15 lines, -13 lines 0 comments Download
M webkit/plugins/ppapi/event_conversion.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M webkit/plugins/ppapi/plugin_module.cc View 2 chunks +8 lines, -1 line 0 comments Download
M webkit/plugins/ppapi/ppapi_plugin_instance.h View 1 chunk +6 lines, -0 lines 0 comments Download
M webkit/plugins/ppapi/ppapi_plugin_instance.cc View 11 chunks +39 lines, -23 lines 0 comments Download
M webkit/plugins/ppapi/ppapi_unittest.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M webkit/plugins/ppapi/resource_tracker_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
dmichael (off chromium)
9 years, 5 months ago (2011-07-20 17:26:53 UTC) #1
brettw
LGTM
9 years, 5 months ago (2011-07-20 17:28:24 UTC) #2
Sergey Ulanov
remoting - LGTM http://codereview.chromium.org/7466002/diff/2030/remoting/client/plugin/pepper_input_handler.h File remoting/client/plugin/pepper_input_handler.h (right): http://codereview.chromium.org/7466002/diff/2030/remoting/client/plugin/pepper_input_handler.h#newcode15 remoting/client/plugin/pepper_input_handler.h:15: nit: don't need this empty line ...
9 years, 5 months ago (2011-07-20 17:41:50 UTC) #3
wez1
The changes under remoting/ look to duplicate http://codereview.chromium.org/7453003/? On 20 July 2011 10:41, <sergeyu@chromium.org> wrote: ...
9 years, 5 months ago (2011-07-20 22:36:53 UTC) #4
dmichael(do not use this one)
9 years, 5 months ago (2011-07-20 22:40:48 UTC) #5
I'm sorry, I wasn't aware of that one. I thought we were ready to go so
pulled the old interface. Then saw that remoting wasn't done, so I did it
quickly. I can circle back and fix anything I did differently in a future
CL, but I really want my CL to stick if that's okay.

On Wed, Jul 20, 2011 at 4:36 PM, Wez <wez@google.com> wrote:

> The changes under remoting/ look to duplicate
> http://codereview.chromium.org/7453003/?
>
>
> On 20 July 2011 10:41, <sergeyu@chromium.org> wrote:
>
>> remoting - LGTM
>>
>>
>> http://codereview.chromium.**org/7466002/diff/2030/**
>>
remoting/client/plugin/pepper_**input_handler.h<http://codereview.chromium.org/7466002/diff/2030/remoting/client/plugin/pepper_input_handler.h>
>> File remoting/client/plugin/pepper_**input_handler.h (right):
>>
>> http://codereview.chromium.**org/7466002/diff/2030/**
>>
remoting/client/plugin/pepper_**input_handler.h#newcode15<http://codereview.chromium.org/7466002/diff/2030/remoting/client/plugin/pepper_input_handler.h#newcode15>
>> remoting/client/plugin/pepper_**input_handler.h:15:
>> nit: don't need this empty line
>>
>> http://codereview.chromium.**org/7466002/diff/2030/**
>>
remoting/client/plugin/pepper_**input_handler.h#newcode18<http://codereview.chromium.org/7466002/diff/2030/remoting/client/plugin/pepper_input_handler.h#newcode18>
>> remoting/client/plugin/pepper_**input_handler.h:18:
>> nit: don't need this empty line
>>
>>
>>
http://codereview.chromium.**org/7466002/<http://codereview.chromium.org/7466...
>>
>
>

Powered by Google App Engine
This is Rietveld 408576698