chrome/browser/metrics/metrics_service.cc - Issue 7466003: MD5Update function uses StringPiece instead of raw buffer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/metrics_service.cc

Issue 7466003: MD5Update function uses StringPiece instead of raw buffer. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: tfarina review Created 9 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/metrics/metrics_service.cc

diff --git a/chrome/browser/metrics/metrics_service.cc b/chrome/browser/metrics/metrics_service.cc

index 45e228d17f4807b68f0415d245289b951bb0ab72..b3039d74de1ffa2964752bc0221aa486abacc864 100644

--- a/chrome/browser/metrics/metrics_service.cc

+++ b/chrome/browser/metrics/metrics_service.cc

@@ -1134,7 +1134,7 @@ MetricsService::LogRecallStatus MetricsService::RecallUnsentLogsHelper(

return MakeRecallStatusHistogram(LOG_STRING_CORRUPTION);

}

- base::MD5Update(&ctx, encoded_log.data(), encoded_log.length());

+ base::MD5Update(&ctx, encoded_log);

if (!base::Base64Decode(encoded_log, &decoded_log)) {

local_list->clear();

@@ -1200,7 +1200,7 @@ void MetricsService::StoreUnsentLogsHelper(

list->Clear();

return;

}

- base::MD5Update(&ctx, encoded_log.data(), encoded_log.length());

+ base::MD5Update(&ctx, encoded_log);

list->Append(Value::CreateStringValue(encoded_log));

}