Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4135)

Unified Diff: chrome/browser/bookmarks/bookmark_codec.cc

Issue 7466003: MD5Update function uses StringPiece instead of raw buffer. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: tfarina review Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/bookmarks/bookmark_codec.cc
diff --git a/chrome/browser/bookmarks/bookmark_codec.cc b/chrome/browser/bookmarks/bookmark_codec.cc
index 548587de7af39fbb797ac62772857407fb07b168..dd0a5766e8aab743cd6e07df43e02c73e36781f2 100644
--- a/chrome/browser/bookmarks/bookmark_codec.cc
+++ b/chrome/browser/bookmarks/bookmark_codec.cc
@@ -338,11 +338,14 @@ void BookmarkCodec::ReassignIDsHelper(BookmarkNode* node) {
}
void BookmarkCodec::UpdateChecksum(const std::string& str) {
- base::MD5Update(&md5_context_, str.data(), str.length() * sizeof(char));
+ base::MD5Update(&md5_context_, str);
}
void BookmarkCodec::UpdateChecksum(const string16& str) {
- base::MD5Update(&md5_context_, str.data(), str.length() * sizeof(char16));
+ base::MD5Update(&md5_context_,
+ base::StringPiece(
+ reinterpret_cast<const char*>(str.data()),
+ str.length() * sizeof(str[0])));
}
void BookmarkCodec::UpdateChecksumWithUrlNode(const std::string& id,

Powered by Google App Engine
This is Rietveld 408576698