Issue 7465084: Minor bugs in Exif parser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7465084: Minor bugs in Exif parser. (Closed)

Created:
9 years, 4 months ago by Vladislav Kaznacheev

Modified:
9 years, 4 months ago

Reviewers:
commit-bot: I haz the power, SeRya, Dmitry Zvorygin

CC:
chromium-reviews, rginda+watch_chromium.org, arv (Not doing code reviews), achuith+watch_chromium.org

Base URL:
http://git.chromium.org/git/chromium.git@trunk

Visibility:
Public.

Minor bugs in Exif parser. Thumbnail parsing should always be in big-endian. Fixed an exception when Exif metadata contains 1-character strings. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95409

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -8 lines)			Patch
	M	chrome/browser/resources/file_manager/js/byte_reader.js	View		2 chunks	+3 lines, -5 lines	0 comments	Download
	M	chrome/browser/resources/file_manager/js/exif_parser.js	View		1 chunk	+5 lines, -3 lines	0 comments	Download

Total messages: 6 (0 generated)

Dmitry Zvorygin

On 2011/08/03 12:52:29, Vladislav Kaznacheev wrote: > Please review. LGTM.

9 years, 4 months ago (2011-08-03 15:56:22 UTC) #2

Change committed as 95409