chrome/browser/resources/file_manager/js/exif_parser.js - Issue 7465084: Minor bugs in Exif parser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/file_manager/js/exif_parser.js

Issue 7465084: Minor bugs in Exif parser. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk

Patch Set: Created 9 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/file_manager/js/exif_parser.js

diff --git a/chrome/browser/resources/file_manager/js/exif_parser.js b/chrome/browser/resources/file_manager/js/exif_parser.js

index af04882328115ce74cc300b2392d5f49cd2896a1..b58259efe98283070aa0337c4173df19b3e6c0cb 100644

--- a/chrome/browser/resources/file_manager/js/exif_parser.js

+++ b/chrome/browser/resources/file_manager/js/exif_parser.js

@@ -249,9 +249,11 @@ ExifParser.prototype.readTagValue = function(br, tag) {

case 2: // String

safeRead(1);

- tag.value = tag.value.map(

- function(v) { return String.fromCharCode(v) });

- tag.value = tag.value.join('');

+ if (tag.componentCount == 1) {

+ tag.value = String.fromCharCode(tag.value);

+ } else {

+ tag.value = String.fromCharCode.apply(null, tag.value);

+ }

break;

case 3: // Short

« no previous file with comments | « chrome/browser/resources/file_manager/js/byte_reader.js ('k') | no next file » | no next file with comments »