Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 7465052: linux: ignore warnings about unused results in third-party code (Closed)

Created:
9 years, 5 months ago by Evan Martin
Modified:
9 years, 5 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

linux: ignore warnings about unused results in third-party code This warning is frequent in our build logs across multiple third-party modules. It seems clear to me that upstreams don't see it in their builds. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=94185

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M build/common.gypi View 1 chunk +3 lines, -0 lines 4 comments Download

Messages

Total messages: 7 (0 generated)
Evan Martin
Sending to some random people who may have some insight
9 years, 5 months ago (2011-07-26 21:42:58 UTC) #1
Evan Martin
On 2011/07/26 21:42:58, Evan Martin wrote: > Sending to some random people who may have ...
9 years, 5 months ago (2011-07-26 21:43:23 UTC) #2
Evan Martin
+sfntly guy who I just also mailed about this warning
9 years, 5 months ago (2011-07-26 21:44:19 UTC) #3
Nico
lgtm sfntly probably wants to set chromium_code in their gyp file to get strict warnings. ...
9 years, 5 months ago (2011-07-26 21:46:48 UTC) #4
Evan Martin
http://codereview.chromium.org/7465052/diff/1/build/common.gypi File build/common.gypi (right): http://codereview.chromium.org/7465052/diff/1/build/common.gypi#newcode917 build/common.gypi:917: 'WARNING_CFLAGS!': ['-Wall', '-Wextra'], On 2011/07/26 21:46:48, Nico wrote: > ...
9 years, 5 months ago (2011-07-26 21:54:07 UTC) #5
Ami GONE FROM CHROMIUM
lgtm http://codereview.chromium.org/7465052/diff/1/build/common.gypi File build/common.gypi (right): http://codereview.chromium.org/7465052/diff/1/build/common.gypi#newcode917 build/common.gypi:917: 'WARNING_CFLAGS!': ['-Wall', '-Wextra'], On 2011/07/26 21:54:07, Evan Martin ...
9 years, 5 months ago (2011-07-26 21:59:37 UTC) #6
Nico
9 years, 5 months ago (2011-07-26 22:04:43 UTC) #7
http://codereview.chromium.org/7465052/diff/1/build/common.gypi
File build/common.gypi (right):

http://codereview.chromium.org/7465052/diff/1/build/common.gypi#newcode917
build/common.gypi:917: 'WARNING_CFLAGS!': ['-Wall', '-Wextra'],
On 2011/07/26 21:54:07, Evan Martin wrote:
> On 2011/07/26 21:46:48, Nico wrote:
> > Add here as well (in a 'WARNING_CFLAGS' block without the !)
> 
> I don't see this warning in the mac build logs.  Maybe it's from a different
> version of gcc?

I tried to look on the clang bots but couldn't find a recent clobber build.

Ok.

Powered by Google App Engine
This is Rietveld 408576698