Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Side by Side Diff: build/common.gypi

Issue 7465052: linux: ignore warnings about unused results in third-party code (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 861 matching lines...) Expand 10 before | Expand all | Expand 10 after
872 '-Wall', 872 '-Wall',
873 '-Wextra', 873 '-Wextra',
874 '-Werror', 874 '-Werror',
875 ], 875 ],
876 'cflags': [ 876 'cflags': [
877 # Don't warn about hash_map in third-party code. 877 # Don't warn about hash_map in third-party code.
878 '-Wno-deprecated', 878 '-Wno-deprecated',
879 # Don't warn about printf format problems. 879 # Don't warn about printf format problems.
880 # This is off by default in gcc but on in Ubuntu's gcc(!). 880 # This is off by default in gcc but on in Ubuntu's gcc(!).
881 '-Wno-format', 881 '-Wno-format',
882 # Don't warn about ignoring the return value from e.g. close().
883 # This is off by default in some gccs but on by default in others.
884 '-Wno-unused-result',
882 ], 885 ],
883 'cflags_cc!': [ 886 'cflags_cc!': [
884 # TODO(fischman): remove this. 887 # TODO(fischman): remove this.
885 # http://code.google.com/p/chromium/issues/detail?id=90453 888 # http://code.google.com/p/chromium/issues/detail?id=90453
886 '-Wsign-compare', 889 '-Wsign-compare',
887 ] 890 ]
888 }], 891 }],
889 [ 'OS=="win"', { 892 [ 'OS=="win"', {
890 'defines': [ 893 'defines': [
891 '_CRT_SECURE_NO_DEPRECATE', 894 '_CRT_SECURE_NO_DEPRECATE',
(...skipping 12 matching lines...) Expand all
904 }], 907 }],
905 # TODO(darin): Unfortunately, some third_party code depends on base/ 908 # TODO(darin): Unfortunately, some third_party code depends on base/
906 [ 'OS=="win" and component=="shared_library"', { 909 [ 'OS=="win" and component=="shared_library"', {
907 'msvs_disabled_warnings': [ 910 'msvs_disabled_warnings': [
908 4251, # class 'std::xx' needs to have dll-interface. 911 4251, # class 'std::xx' needs to have dll-interface.
909 ], 912 ],
910 }], 913 }],
911 [ 'OS=="mac"', { 914 [ 'OS=="mac"', {
912 'xcode_settings': { 915 'xcode_settings': {
913 'GCC_TREAT_WARNINGS_AS_ERRORS': 'NO', 916 'GCC_TREAT_WARNINGS_AS_ERRORS': 'NO',
914 'WARNING_CFLAGS!': ['-Wall', '-Wextra'], 917 'WARNING_CFLAGS!': ['-Wall', '-Wextra'],
Nico 2011/07/26 21:46:48 Add here as well (in a 'WARNING_CFLAGS' block with
Evan Martin 2011/07/26 21:54:07 I don't see this warning in the mac build logs. M
Ami GONE FROM CHROMIUM 2011/07/26 21:59:38 mac builders use gcc 4.2?
Nico 2011/07/26 22:04:43 I tried to look on the clang bots but couldn't fin
915 }, 918 },
916 }], 919 }],
917 ], 920 ],
918 }, { 921 }, {
919 # In Chromium code, we define __STDC_FORMAT_MACROS in order to get the 922 # In Chromium code, we define __STDC_FORMAT_MACROS in order to get the
920 # C99 macros on Mac and Linux. 923 # C99 macros on Mac and Linux.
921 'defines': [ 924 'defines': [
922 '__STDC_FORMAT_MACROS', 925 '__STDC_FORMAT_MACROS',
923 ], 926 ],
924 'conditions': [ 927 'conditions': [
(...skipping 963 matching lines...) Expand 10 before | Expand all | Expand 10 after
1888 # settings in target dicts. SYMROOT is a special case, because many other 1891 # settings in target dicts. SYMROOT is a special case, because many other
1889 # Xcode variables depend on it, including variables such as 1892 # Xcode variables depend on it, including variables such as
1890 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 1893 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
1891 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 1894 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
1892 # files to appear (when present) in the UI as actual files and not red 1895 # files to appear (when present) in the UI as actual files and not red
1893 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 1896 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
1894 # and therefore SYMROOT, needs to be set at the project level. 1897 # and therefore SYMROOT, needs to be set at the project level.
1895 'SYMROOT': '<(DEPTH)/xcodebuild', 1898 'SYMROOT': '<(DEPTH)/xcodebuild',
1896 }, 1899 },
1897 } 1900 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698